From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tolunay Orkun <listmember@orkun.us>
Date: Thu, 03 May 2007 16:06:16 -0500
Subject: [U-Boot-Users] [PATCH] cfi_flash.c: use addr2info
In-Reply-To: <20070503100453.GA5146@michl.2n.cz>
References: <20070323115235.GA4857@michl.2n.cz>
	<20070424102648.GA18388@michl.2n.cz>
	<463907B8.3060104@orkun.us> <20070503100453.GA5146@michl.2n.cz>
Message-ID: <463A4EC8.9080301@orkun.us>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Ladislav Michl wrote:
> On Wed, May 02, 2007 at 04:50:48PM -0500, Tolunay Orkun wrote:
>> I looked at your patch when you submitted but did not carefully review 
>> yet. I feel like the function should reside inside the flash driver 
>> where it is most often used and flash driver should export it.
> 
> I disagree. This function (addr2info) is used also by board specific
> drivers as well as by common/cmd_load.c, common/cmd_bootm.c and
> common/cmd_mem.c. Therefore it should reside in common/flash.c - to
> be used by either board specific driver or cfi driver.
> 
> Best regards,
> 	ladis

Landis,

I was referring to the frequency of the use of the function during flash 
programming. I am use it is called elsewhere but when the function is in 
the same file compiler has more opportunities to optimize. That is why I 
prefer the function stay in the flash driver and exported from there.

Tolunay