[U-Boot-Users] [PATCH v3] Fix initrd length miscalculation in bootm command when using a dtu

Timur Tabi
2007-05-04T19:40:27Z

Wolfgang Denk wrote:
> In message <463B6022.7000908@freescale.com> you wrote:
>> Really? I doubt it. Every other place that len is used, it's the initrd length. Can you
>> show me where that's not the case?
>
> See for example line 656: len = sizeof(image_header_t);

Wolfgang, look at my patch!!!!

@@ -652,13 +652,10 @@ do_bootm_linux (cmd_tbl_t *cmdtp, int flag,
do_reset (cmdtp, flag, argc, argv);
}

- data = (ulong)&header;
- len = sizeof(image_header_t);
-
checksum = ntohl(hdr->ih_hcrc);
hdr->ih_hcrc = 0;

- if (crc32 (0, (uchar *)data, len) != checksum) {
+ if (crc32 (0, (uchar *) &header, sizeof(image_header_t)) != checksum) {
puts ("Bad Header Checksum\n");
SHOW_BOOT_PROGRESS (-11);
do_reset (cmdtp, flag, argc, argv);

My patch deletes that usage of 'len'!!! *Your* patch doesn't!

>> It would be the same IP address that Kim, Andy, and Jon use. As soon as I get hold of one
>
> And that is???

I just spoke to Andy, and he never gave you the IP address comes from, so I don't
understand why you need from him but didn't need it from him. Regardless, I'm going to
try to figure out the IP address, and I'll send you another email.

--
Timur Tabi
Linux Kernel Developer @ Freescale