From: Michal Simek <michal.simek@amd.com>
To: Simon Glass <sjg@chromium.org>
Cc: <u-boot@lists.denx.de>, <git@xilinx.com>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header
Date: Mon, 25 Sep 2023 08:05:51 +0200 [thread overview]
Message-ID: <463b713f-97f2-492e-a87b-e71b6d2020ea@amd.com> (raw)
In-Reply-To: <CAPnjgZ1hf68F3YKTp1p3ruTG2vhgg+F=rn3=2DTZCTTTWnQeUg@mail.gmail.com>
Hi Simon,
On 9/23/23 20:13, Simon Glass wrote:
> Current alignment which is using 16 bytes is not correct in connection to
> trace_clocks description and it's length.
> That's why use start_addr variable and record proper size based on used
> entries.
>
> Fixes: be16fc81b2ed ("trace: Update proftool to use new binary format").
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - s/start_addr/start_ofs/g'
>
> tools/proftool.c | 31 +++++++++++++++++++++++++++++--
> 1 file changed, 29 insertions(+), 2 deletions(-)
>
> Applied to u-boot-dm, thanks!
FYI: I have merged it to my tree and already sent pull request to Tom.
Without it I couldn't pass CI loop to get all reviewed features in.
https://lore.kernel.org/all/ab72c480-e9f8-416e-adf5-726f7d40c4f5@amd.com/
Thanks,
Michal
next prev parent reply other threads:[~2023-09-25 6:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 12:12 [PATCH v2 0/3] trace: Fix flyrecord alignment issue Michal Simek
2023-09-15 12:12 ` [PATCH v2 1/3] trace: Use 64bit variable for start and len Michal Simek
2023-09-23 18:13 ` Simon Glass
2023-09-15 12:12 ` [PATCH v2 2/3] trace: Move trace_clocks description above record offset calculation Michal Simek
2023-09-23 18:13 ` Simon Glass
2023-09-15 12:12 ` [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header Michal Simek
2023-09-23 18:13 ` Simon Glass
2023-09-25 6:05 ` Michal Simek [this message]
2023-09-25 13:10 ` Simon Glass
2023-09-25 13:38 ` Michal Simek
2023-09-25 14:01 ` Simon Glass
2023-09-25 14:10 ` Michal Simek
2023-09-25 14:19 ` Tom Rini
2023-09-25 14:21 ` Michal Simek
2023-09-25 14:33 ` Tom Rini
2023-10-24 12:33 ` Michal Simek
2023-10-24 18:03 ` Tom Rini
2023-10-25 7:33 ` Michal Simek
2023-10-25 14:19 ` Tom Rini
2023-09-25 14:28 ` Tom Rini
2023-09-25 14:43 ` Michal Simek
2023-09-21 11:07 ` [PATCH v2 0/3] trace: Fix flyrecord alignment issue Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463b713f-97f2-492e-a87b-e71b6d2020ea@amd.com \
--to=michal.simek@amd.com \
--cc=git@xilinx.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox