From: Matthieu CASTET <matthieu.castet@parrot.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] RO jffs2 implementation for bootloader
Date: Wed, 16 May 2007 14:17:17 +0200 [thread overview]
Message-ID: <464AF64D.2010803@parrot.com> (raw)
In-Reply-To: <20070516110027.GB5782@michl.2n.cz>
Hi Ladislav,
Ladislav Michl a ?crit :
> On Mon, May 07, 2007 at 07:38:20PM +0200, Stefan Roese wrote:
>> Hi Matthieu,
>>
>> On Monday 07 May 2007, Matthieu CASTET wrote:
>>> Using jffs2_nand_1pass.c make thing lot's of better (very fast scaning)
>>>
>>> Unfortunalty the code seems incomplete : if I do a ls, there are missing
>>> files.
>> Do I understand this correctly? Some files are displayed and some are missing?
>> Could you give an example?
>
> I'm also interrested in test case. Having filesystem image would help as
> well.
The problem is that delete file are not handled :
image we have 2 dirent :
pino=1 ino=4 name=toto version=1
pino=1 ino=0 name=toto version=5
jffs2_1pass_list_inodes will list all dirent inode ie diplay version 1
and ignore version 5.
>
>>> Do you know what's the status of jffs2_nand_1pass.c ?
>> No, sorry I personally haven't used the JFFS2 code in U-Boot before.
>>
>> IIRC this code originally is coming from Ladislav Michl (please correct me if
>> I'm wrong here). So Ladis, can you say something about the status of this
>> file and why it not used at all?
>
> Indeed... I wrote it (modified from jffs2_1pass.c) when I was adding NAND
> code. Unfortunately it is not that easy to support JFFS2 on NOR and NAND
> simultaneously. It would need more work...
I found that jffs2_1pass_read_inode code is buggy on garbage collected
image : we should load inode in version order (small first).
If we don't, obsolete inode could be put in the final file.
ino=4 offset=5 dsize=5 version=4
ino=4 offset=0 dsize=5 version=1
ino=4 offset=5 dsize=5 version=2
The code will load version 4, version 1 and version 2. In the dest we
will have version 1 & 2 instead of version 1 & 4.
Matthieu
next prev parent reply other threads:[~2007-05-16 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <loom.20070503T102421-36@post.gmane.org>
[not found] ` <1178186163.7539.62.camel@sauron>
[not found] ` <463B02F5.6060503@parrot.com>
[not found] ` <200705041353.43372.sr@denx.de>
2007-05-04 12:10 ` [U-Boot-Users] RO jffs2 implementation for bootloader Matthieu CASTET
2007-05-04 12:23 ` Stefan Roese
2007-05-07 14:59 ` Matthieu CASTET
2007-05-07 17:38 ` Stefan Roese
2007-05-09 8:25 ` Matthieu CASTET
2007-05-16 11:00 ` Ladislav Michl
2007-05-16 12:17 ` Matthieu CASTET [this message]
2007-05-16 12:36 ` Ladislav Michl
2007-05-16 12:45 ` Matthieu CASTET
2007-05-18 10:59 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464AF64D.2010803@parrot.com \
--to=matthieu.castet@parrot.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox