[U-Boot-Users] Altera Stratix II support

Wolfgang Denk
2007-05-31T23:46:12Z

In message <ffc2b1d40705311610j405896f7yeb9b89268d9477de@mail.gmail.com> you wrote:
>
> I have attached two patches which are applied against the latest
> stable u-boot-1.1.6.

U-Boot 1.1.6 is by far not "latest". Actually it is very old and
outdated. Please resubmit your patches against *current* code, i. e.
against the top-of-tree version in the git repository.

Your patches cannot be applied current code:

-> patch -p1 --dry-run </tmp/patch1
patching file common/altera.c
Hunk #4 FAILED at 60.
Hunk #5 succeeded at 99 (offset 5 lines).
Hunk #6 succeeded at 218 with fuzz 2 (offset 90 lines).
Hunk #7 FAILED at 243.
Hunk #8 FAILED at 263.
Hunk #9 FAILED at 306.
Hunk #10 succeeded at 164 (offset -71 lines).
4 out of 10 hunks FAILED -- saving rejects to file common/altera.c.rej
patching file common/fpga.c
patching file common/Makefile
Hunk #1 FAILED at 27.
1 out of 1 hunk FAILED -- saving rejects to file common/Makefile.rej
patching file common/stratixII.c
patching file include/altera.h
Hunk #1 FAILED at 27.
Hunk #2 FAILED at 49.
Hunk #3 succeeded at 92 (offset 4 lines).
2 out of 3 hunks FAILED -- saving rejects to file include/altera.h.rej
patching file include/common.h
Hunk #1 succeeded at 559 (offset 8 lines).
patching file include/exports.h
patching file include/stratixII.h
patching file lib_ppc/time.c

Also, please clean up all your many coding style violations (see
http://www.denx.de/wiki/UBoot/CodingStyle): trailing white space,
indentation not by TABs, too long lines, indentation not by multiples
of 8 characters, missing space after function names, bad brace style
(board/extricom/exsw6000/exsw6000_fpga.c), etc.

Also, please make sure to keep lists (like of objects) alphabetically
sorted (common/Makefile etc.).

Also, make sure that "make clean" removes all files and directories
you create during your build ($(obj)../../cds/common ?).

Finally, please break up your monster patches into smaller, indepen-
dent chunks. For example, adding the "bunzip" command to
common/cmd_misc.c is unrelated to the rest of your patches and must
be submitted as a separate patch. Ditto for your changes to
drivers/cfi_flash.c and other similar things.

Thanks.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"In the long run, every program becomes rococo, and then rubble."
- Alan Perlis