From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Date: Tue, 19 Sep 2017 10:05:31 +0100 Subject: [U-Boot] [RESEND PATCH 3/3] dts: sunxi: add PWM node for sun50i In-Reply-To: <20170919050641.23305-3-anarsoul@gmail.com> References: <20170919050641.23305-1-anarsoul@gmail.com> <20170919050641.23305-3-anarsoul@gmail.com> Message-ID: <464f41c6-99ca-afb4-22e6-1fdca29d6493@arm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 19/09/17 06:06, Vasily Khoruzhick wrote: > Signed-off-by: Vasily Khoruzhick > --- > arch/arm/dts/sun50i-a64.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/dts/sun50i-a64.dtsi b/arch/arm/dts/sun50i-a64.dtsi > index 65a344d9ce..14e94bf00e 100644 > --- a/arch/arm/dts/sun50i-a64.dtsi > +++ b/arch/arm/dts/sun50i-a64.dtsi > @@ -319,6 +319,14 @@ > }; > }; > > + pwm: pwm at 01c21400 { > + compatible = "allwinner,sun50i-a64-pwm"; So the A64 PWM seems to be fully compatible with the H3 one, which has a documented binding (also used in the Linux driver). So can you please make this: compatible = "allwinner,sun50i-a64-pwm", "allwinner,sun8i-h3-pwm"; and then drop the sun50i-a64-pwm string in the driver? And I wonder if we should have the pinctrl already in here, since there is only one choice for PWM0? At least that would document the clash. > + reg = <0x01c21400 0x8>; > + clocks = <&osc24M>; > + #pwm-cells = <3>; > + status = "disabled"; > + }; > + > uart0: serial at 1c28000 { > compatible = "snps,dw-apb-uart"; > reg = <0x01c28000 0x400>; >