public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT
Date: Wed, 23 May 2007 10:09:04 -0500	[thread overview]
Message-ID: <46545910.4030503@freescale.com> (raw)
In-Reply-To: <200705231245.24522@sercond.localdomain>

Nikita V. Youshchenko wrote:
> Current include/configs/MPC8349ITX.h does contain some support for building
> image that will be started from memory (without putting in into flash).
> It could be triggered by building with TEXT_BASE set to a low value.

Well that's ironic.  I was just about to remove support for ramboot altogether from all 
8xxx boards.

I guess I won't be doing that.  However, I have to NACK your patch for one reason:

> -#define CONFIG_COMMANDS                (CONFIG_CMD_DFL | \
> +#ifdef CFG_NO_FLASH
> +#define CONFIG_COMMANDS_DEFAULT (CONFIG_CMD_DFL & ~(CFG_CMD_FLASH | \
> +                                                   CFG_CMD_IMLS))
> +#else
> +#define CONFIG_COMMANDS_DEFAULT CONFIG_CMD_DFL
> +#endif

Please don't put CONFIG_COMMANDS inside an #ifdef block.  Instead, please follow the 
example of CONFIG_COMMANDS_CF.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

  reply	other threads:[~2007-05-23 15:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23  8:45 [U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT Nikita V. Youshchenko
2007-05-23 15:09 ` Timur Tabi [this message]
2007-05-23 15:37   ` Nikita V. Youshchenko
2007-05-23 15:55     ` Timur Tabi
2007-05-23 16:30       ` Wolfgang Denk
2007-05-23 16:50         ` Timur Tabi
2007-05-23 16:52 ` Timur Tabi
2007-05-23 18:59   ` Nikita V. Youshchenko
2007-05-23 19:08     ` Timur Tabi
2007-05-23 17:48 ` Timur Tabi
2007-05-23 18:38   ` Wolfgang Denk
2007-05-23 18:43     ` Timur Tabi
2007-05-23 19:51       ` Wolfgang Denk
2007-05-23 20:01         ` Nikita V. Youshchenko
2007-05-23 20:13         ` Nikita V. Youshchenko
2007-05-23 23:11           ` Wolfgang Denk
2007-05-24  8:10             ` Nikita V. Youshchenko
2007-05-24 12:36               ` Wolfgang Denk
2007-05-24 12:49                 ` Jerry Van Baren
2007-05-24 15:25                 ` Timur Tabi
2007-05-24 18:36                 ` Jon Loeliger
2007-05-24 18:38                   ` Timur Tabi
2007-05-24 19:43                   ` Wolfgang Grandegger
2007-05-24 12:39               ` Wolfgang Grandegger
2007-05-23 20:29         ` Timur Tabi
2007-06-01 20:18 ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46545910.4030503@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox