From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@freescale.com>
Date: Wed, 23 May 2007 10:55:13 -0500
Subject: [U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx
 CFG_RAMBOOT
In-Reply-To: <200705231937.35200@sercond.localdomain>
References: <200705231245.24522@sercond.localdomain>
	<46545910.4030503@freescale.com>
	<200705231937.35200@sercond.localdomain>
Message-ID: <465463E1.6050000@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Nikita V. Youshchenko wrote:

> I guess I'm not alone in such a situation. So please don't remove ramboot 
> support.

Ok, I'll keep it.  But I think you need to expand your patch to fix this problem:

    #define CFG_ENV_ADDR		(CFG_MONITOR_BASE - 0x1000)
    #define CFG_ENV_SIZE		0x2000

The environment is located 0x1000 bytes before the start of U-Boot, but 0x2000 bytes have 
been reserved.

Your patch should probably change the above lines to:

    #define CFG_ENV_SIZE		0x2000
    #define CFG_ENV_ADDR		(CFG_MONITOR_BASE - CFG_ENV_SIZE)

However, Wolfgang says this is still wrong, but he won't explain why.  What do you think?

> Could you please explain what you mean?
> 
> I don't put CONFIG_COMMANDS under #ifdef.

Sorry, I misread your patch.  I have a crappy monitor.

> I put another macro, CONFIG_COMMANDS_DEFAULT, under ifdef.
> And then use it in unconditional CONFIG_COMMANDS definition.
> Looks similar to CONFIG_COMMANDS_CF and others.
> The difference from CONFIG_COMMANDS_CF is that I have to exclude bits from 
> CONFIG_CMD_DFL, not add more commands.

Ok, I understand now.  This part is fine.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale