From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT
Date: Thu, 24 May 2007 14:39:59 +0200 [thread overview]
Message-ID: <4655879F.2050508@grandegger.com> (raw)
In-Reply-To: <200705241210.19623@zigzag.lvk.cs.msu.su>
Nikita V. Youshchenko wrote:
>>> In this case:
>>> - command xxx could be compiled in, if CONFIG_CMD_XXX is defined, and
>>> not> compiled in if not defined;
>>> - it could be easy to define/undefine such macros in config
>> But you get problems when you want to configure a board with settings
>> like:
>>
>> * all commands except foo, bar and baz
>
> #include "define_all_cmds.h"
> #undef CONFIG_CMD_FOO
> #undef CONFIG_CMD_BAR
> #undef CONFIG_CMD_BAZ
>
>> * all default commands plus foo, but without baz
>
> #include "define_default_cmds.h"
> #define CONFIG_CMD_FOO
> #undef CONFIG_CMD_BAZ
>
>> I guess then you will have to list up all commands you want to
>> include somewhere - either in the board onfig file or in another
>> header file.
>
> Sure - in separate headers files. I see no problems here. It scales.
Full ack. We need an include file for the default commands
(cmd_default.h) and one for all other commands (cmd_not_default.h). And
"cmd_all.h" will include both. Then you can do exactly the same as with
the bit masks and it scales nicely.
Wolfgang.
next prev parent reply other threads:[~2007-05-24 12:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 8:45 [U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT Nikita V. Youshchenko
2007-05-23 15:09 ` Timur Tabi
2007-05-23 15:37 ` Nikita V. Youshchenko
2007-05-23 15:55 ` Timur Tabi
2007-05-23 16:30 ` Wolfgang Denk
2007-05-23 16:50 ` Timur Tabi
2007-05-23 16:52 ` Timur Tabi
2007-05-23 18:59 ` Nikita V. Youshchenko
2007-05-23 19:08 ` Timur Tabi
2007-05-23 17:48 ` Timur Tabi
2007-05-23 18:38 ` Wolfgang Denk
2007-05-23 18:43 ` Timur Tabi
2007-05-23 19:51 ` Wolfgang Denk
2007-05-23 20:01 ` Nikita V. Youshchenko
2007-05-23 20:13 ` Nikita V. Youshchenko
2007-05-23 23:11 ` Wolfgang Denk
2007-05-24 8:10 ` Nikita V. Youshchenko
2007-05-24 12:36 ` Wolfgang Denk
2007-05-24 12:49 ` Jerry Van Baren
2007-05-24 15:25 ` Timur Tabi
2007-05-24 18:36 ` Jon Loeliger
2007-05-24 18:38 ` Timur Tabi
2007-05-24 19:43 ` Wolfgang Grandegger
2007-05-24 12:39 ` Wolfgang Grandegger [this message]
2007-05-23 20:29 ` Timur Tabi
2007-06-01 20:18 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4655879F.2050508@grandegger.com \
--to=wg@grandegger.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox