public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT
Date: Thu, 24 May 2007 10:25:28 -0500	[thread overview]
Message-ID: <4655AE68.3030504@freescale.com> (raw)
In-Reply-To: <20070524123653.1231835264E@atlas.denx.de>

Wolfgang Denk wrote:

> Good idea. Shall we go for that?
> 
> Any other opinions, ACKs or NACKs?

ACK.  I like it.  The header files should all start with the same name, like 
config_defaults.h and config_all.h.  And config_defaults should contain a list of ALL 
options, using #define to turn on options and #undef to turn off options.  Yes, the 
#undefs are redundant, but then you can use that file as a reference.  It would also be 
nice if the documentation for these options were moved from the README to this file.  My 
text editor has the ability to display comments for any identifier if I just however the 
mouse over it.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

  parent reply	other threads:[~2007-05-24 15:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23  8:45 [U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT Nikita V. Youshchenko
2007-05-23 15:09 ` Timur Tabi
2007-05-23 15:37   ` Nikita V. Youshchenko
2007-05-23 15:55     ` Timur Tabi
2007-05-23 16:30       ` Wolfgang Denk
2007-05-23 16:50         ` Timur Tabi
2007-05-23 16:52 ` Timur Tabi
2007-05-23 18:59   ` Nikita V. Youshchenko
2007-05-23 19:08     ` Timur Tabi
2007-05-23 17:48 ` Timur Tabi
2007-05-23 18:38   ` Wolfgang Denk
2007-05-23 18:43     ` Timur Tabi
2007-05-23 19:51       ` Wolfgang Denk
2007-05-23 20:01         ` Nikita V. Youshchenko
2007-05-23 20:13         ` Nikita V. Youshchenko
2007-05-23 23:11           ` Wolfgang Denk
2007-05-24  8:10             ` Nikita V. Youshchenko
2007-05-24 12:36               ` Wolfgang Denk
2007-05-24 12:49                 ` Jerry Van Baren
2007-05-24 15:25                 ` Timur Tabi [this message]
2007-05-24 18:36                 ` Jon Loeliger
2007-05-24 18:38                   ` Timur Tabi
2007-05-24 19:43                   ` Wolfgang Grandegger
2007-05-24 12:39               ` Wolfgang Grandegger
2007-05-23 20:29         ` Timur Tabi
2007-06-01 20:18 ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4655AE68.3030504@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox