From: Jerry Van Baren <gerald.vanbaren@smiths-aerospace.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Imminent u-boot-fdt pull request
Date: Fri, 25 May 2007 07:54:47 -0400 [thread overview]
Message-ID: <4656CE87.8080200@smiths-aerospace.com> (raw)
In-Reply-To: <20070524222612.381a3587.kim.phillips@freescale.com>
Kim Phillips wrote:
> On Tue, 22 May 2007 00:06:06 -0400
> Jerry Van Baren <gvb.uboot@gmail.com> wrote:
>
>> Dear all,
>>
>> Please review the u-boot-fdt changes. I intend to request Wolfgang pull
>> the pending changes soon. All of the changes (except the last trivial
>
> I have properties being placed at the wrong level, timebase- and
> bus-frequencies not being updated, there are multiple copies of the
> code, and, it is hard to read - I saw a line length of 139!
>
> Please work on your CodingStyle. I haven't finished debugging here.
>
> Kim
Hi Kim,
Thanks for the feedback, I'll check things. Pointers to files (and
lines) would be helpful. :-/
WRT line lengths, Wolfgang dinged me on them so I created a cleanup
patch. As a result, one patch has line length violations and a later
patch fixes them. This may be related to your line length and multiple
copy comment.
Thanks,
gvb
next prev parent reply other threads:[~2007-05-25 11:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 4:06 [U-Boot-Users] Imminent u-boot-fdt pull request Jerry Van Baren
2007-05-25 3:26 ` Kim Phillips
2007-05-25 9:27 ` Wolfgang Grandegger
2007-05-25 15:58 ` Kim Phillips
2007-05-25 16:56 ` Jerry Van Baren
2007-05-25 17:13 ` Kim Phillips
2007-05-25 17:33 ` Jerry Van Baren
2007-05-25 19:36 ` Kim Phillips
2007-05-25 20:18 ` Jerry Van Baren
2007-05-25 18:05 ` Scott Wood
2007-05-25 18:12 ` [U-Boot-Users] HUSH local variables visibility in u-boot code Leonid
2007-05-25 19:33 ` Wolfgang Denk
2007-05-25 18:15 ` [U-Boot-Users] Imminent u-boot-fdt pull request Jerry Van Baren
2007-05-25 18:17 ` Scott Wood
2007-05-25 18:31 ` Jerry Van Baren
2007-05-25 17:06 ` Jerry Van Baren
2007-05-25 11:54 ` Jerry Van Baren [this message]
2007-05-25 15:58 ` Kim Phillips
2007-05-25 16:28 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4656CE87.8080200@smiths-aerospace.com \
--to=gerald.vanbaren@smiths-aerospace.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox