public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@smiths-aerospace.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Imminent u-boot-fdt pull request
Date: Fri, 25 May 2007 12:28:19 -0400	[thread overview]
Message-ID: <46570EA3.2060300@smiths-aerospace.com> (raw)
In-Reply-To: <20070525105839.1717a181.kim.phillips@freescale.com>

Kim Phillips wrote:
> On Fri, 25 May 2007 07:54:47 -0400
> Jerry Van Baren <gerald.vanbaren@smiths-aerospace.com> wrote:
> 
>> Thanks for the feedback, I'll check things.  Pointers to files (and 
>> lines) would be helpful.  :-/
>>
>> WRT line lengths, Wolfgang dinged me on them so I created a cleanup 
>> patch.  As a result, one patch has line length violations and a later 
>> patch fixes them.  This may be related to your line length and multiple 
>> copy comment.
>>
>> Thanks,
>> gvb
> 
> $ wc -L common/fdt_support.c
>     139 common/fdt_support.c
> 
> introduced by:
> 
> commit 792f0989bf90961ba2644ccc718cf09d338706b8
> Author: Gerald Van Baren <vanbaren@cideas.com>
> Date:   Wed May 16 22:39:59 2007 -0400
> 
>     Fix cmd_fdt line lengths, refactor code.
> 
>     Break lines that were greater than 80 characters in length.
>     Move the fdt print and property parsing code to separate static functions
>       to reduce coding clutter in the fdt_cmd handling body.
> 
>     Signed-off-by: Gerald Van Baren <vanbaren@cideas.com>
> 
> Kim

Hmm, looks like I did a half-a$$ job there.  Looking at the patch, I 
only cleaned up cmd_fdt and missed cleaning up the long lines in 
fdt_+support.c.

Sorry for the sloppiness, I'll fix that.

Best regards,
gvb

      reply	other threads:[~2007-05-25 16:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-22  4:06 [U-Boot-Users] Imminent u-boot-fdt pull request Jerry Van Baren
2007-05-25  3:26 ` Kim Phillips
2007-05-25  9:27   ` Wolfgang Grandegger
2007-05-25 15:58     ` Kim Phillips
2007-05-25 16:56       ` Jerry Van Baren
2007-05-25 17:13         ` Kim Phillips
2007-05-25 17:33           ` Jerry Van Baren
2007-05-25 19:36             ` Kim Phillips
2007-05-25 20:18               ` Jerry Van Baren
2007-05-25 18:05         ` Scott Wood
2007-05-25 18:12           ` [U-Boot-Users] HUSH local variables visibility in u-boot code Leonid
2007-05-25 19:33             ` Wolfgang Denk
2007-05-25 18:15           ` [U-Boot-Users] Imminent u-boot-fdt pull request Jerry Van Baren
2007-05-25 18:17             ` Scott Wood
2007-05-25 18:31               ` Jerry Van Baren
2007-05-25 17:06       ` Jerry Van Baren
2007-05-25 11:54   ` Jerry Van Baren
2007-05-25 15:58     ` Kim Phillips
2007-05-25 16:28       ` Jerry Van Baren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46570EA3.2060300@smiths-aerospace.com \
    --to=gerald.vanbaren@smiths-aerospace.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox