From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Fri, 25 May 2007 14:15:06 -0400 Subject: [U-Boot-Users] Imminent u-boot-fdt pull request In-Reply-To: <4657255C.8040405@freescale.com> References: <46526C2E.3070100@gmail.com> <20070524222612.381a3587.kim.phillips@freescale.com> <4656AC13.2010300@grandegger.com> <20070525105833.3d1dbd0e.kim.phillips@freescale.com> <4657152D.7030606@smiths-aerospace.com> <4657255C.8040405@freescale.com> Message-ID: <465727AA.3040104@smiths-aerospace.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Scott Wood wrote: > Jerry Van Baren wrote: >> FWIIW, that is in the (infamous) common/fdt_support.c. It was adapted >> from ft_build.c. It looks like I lost a OF_CPU in the constructed >> string when I was adapting. >> >> Original code: >> p = ft_get_prop(blob, "/cpus/" OF_CPU "/clock-frequency", &len); >> >> Comments: >> 1) It looks like you are missing the OF_CPU definition, or I'm not >> pulling in the right .h file > > What about doing a search for device_type = "cpu", rather than looking > for a specific CPU name? The Linux bootwrapper does it this way. It > also has the benefit of working when there's more than one CPU. > > -Scott I deeply regret the confusion I caused by pushing the "Send" when I meant to push "Write" to start a new, unrelated, message. My updated re-send, as you probably have figured out by now, is more coherent. OF_CPU is defined in the board-specific header file, e.g. configs/MPC8360EMDS.h, pulled in by config.h. Since I am missing the #include in the two files being discussed, OF_CPU is undefined and the string concatenation trick makes it silently disappear. Best regards, gvb