From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Date: Tue, 21 May 2013 19:15:17 +0200 (CEST) Subject: [U-Boot] [PATCH v3 3/6] net: fec_mxc: Add support for Vybrid MVF600 In-Reply-To: <1369126981-13970-4-git-send-email-b18965@freescale.com> References: <1369126981-13970-1-git-send-email-b18965@freescale.com> <1369126981-13970-4-git-send-email-b18965@freescale.com> Message-ID: <465973883.1020444.1369156517526.JavaMail.root@advansee.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Alison, On Tuesday, May 21, 2013 11:02:58 AM, Alison Wang wrote: > This patch adds FEC support for Vybrid MVF600 platform. > > In function fec_open(), RCR register is only set as RGMII mode. But RCR > register should be set as RMII mode for MVF600 platform. > This configuration is already done in fec_reg_setup(), so this piece of > code could just leave untouched the FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / > FEC_RCNTRL_MII_MODE bits. > > Signed-off-by: Alison Wang > --- > Changes in v3: > - Remove the changes for FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / > FEC_RCNTRL_MII_MODE bits, as they are already set in fec_reg_setup() > > Changes in v2: > - Use common FEC driver fec_mxc.c > > drivers/net/fec_mxc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index 4dbcdca..da95e28 100644 > --- a/drivers/net/fec_mxc.c > +++ b/drivers/net/fec_mxc.c > @@ -516,9 +516,7 @@ static int fec_open(struct eth_device *edev) > #ifdef FEC_QUIRK_ENET_MAC > { > u32 ecr = readl(&fec->eth->ecntrl) & ~FEC_ECNTRL_SPEED; > - u32 rcr = (readl(&fec->eth->r_cntrl) & > - ~(FEC_RCNTRL_RMII | FEC_RCNTRL_RMII_10T)) | > - FEC_RCNTRL_RGMII | FEC_RCNTRL_MII_MODE; > + u32 rcr = readl(&fec->eth->r_cntrl) & ~FEC_RCNTRL_RMII_10T; > if (speed == _1000BASET) > ecr |= FEC_ECNTRL_SPEED; > else if (speed != _100BASET) Reviewed-by: Beno?t Th?baudeau Best regards, Beno?t