[U-Boot-Users] Patch fixes bug for clearing the bss section

[U-Boot-Users] Patch fixes bug for clearing the bss section

[mushtaq khan]

Hi,
There is a bug in the code of clearing the bss section for processor 
i386.(File: cpu/i386/start.S)
In the code, bss_start addr (starting addr of bss section) is put into 
the register %eax, but the code which clears the bss section refers to 
the addr pointed by %edi.

This patch fixes this bug by putting bss_start into %edi register.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bss_clear.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070430/77637fd9/attachment.txt 

[U-Boot-Users] Patch fixes bug for clearing the bss section

[Wolfgang Denk]

In message <4635C48A.5050703@procsys.com> you wrote:
> 
> Hi,
> There is a bug in the code of clearing the bss section for processor 
> i386.(File: cpu/i386/start.S)
> In the code, bss_start addr (starting addr of bss section) is put into 
> the register %eax, but the code which clears the bss section refers to 
> the addr pointed by %edi.
> 
> This patch fixes this bug by putting bss_start into %edi register.

Applied to u-boot-testing.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would seem that evil retreats when forcibly confronted
	-- Yarnek of Excalbia, "The Savage Curtain", stardate 5906.5

[U-Boot-Users] Patch fixes bug for clearing the bss section

[mushtaq khan]

Hi Wolfgang Denk,
   
    Any  issues with my Patches, SATA and clearing of bss section. 
Please update me.

Thanks,
-Mushtaq



Wolfgang Denk wrote:

>In message <4635C48A.5050703@procsys.com> you wrote:
>  
>
>>Hi,
>>There is a bug in the code of clearing the bss section for processor 
>>i386.(File: cpu/i386/start.S)
>>In the code, bss_start addr (starting addr of bss section) is put into 
>>the register %eax, but the code which clears the bss section refers to 
>>the addr pointed by %edi.
>>
>>This patch fixes this bug by putting bss_start into %edi register.
>>    
>>
>
>Applied to u-boot-testing.
>
>Thanks.
>
>Best regards,
>
>Wolfgang Denk
>
>  
>

[U-Boot-Users] Patch fixes bug for clearing the bss section

[Wolfgang Denk]

In message <4660188C.9070907@procsys.com> you wrote:
> 
>     Any  issues with my Patches, SATA and clearing of bss section. 
> Please update me.

I wrote:

> >Applied to u-boot-testing.

Did you test the code in the u-boot-testing  repository?  I  did  not
receive any feedback from you (nor any form others).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You see but you do not observe.
Sir Arthur Conan Doyle, in "The Memoirs of Sherlock Holmes"

[U-Boot-Users] Patch fixes bug for clearing the bss section

[mushtaq khan]

Hi  Wolfgang Denk,
 
I tested my patches in u-boot-testing
1. Clearing of bss section patch  and
2. Sata patch.

Clearing of  bss section patch has no issues.
But with sata patch, got compilation warning:  fuinction proto-type 
mismatch between block_read and sata_read.

This is becuase i had been working on u-boot downloaded on feb-15th. And 
on Apr-13th, patch  "Fix use of "void *" for block dev read/write buffer 
pointers" has been applied, which has changed the proto-type of 
block_read function.

I will bring these changes to my patch. And after testing , i will 
re-submit the patch.

Thanks,
-Mushtaq Khan.









Wolfgang Denk wrote:

>In message <4660188C.9070907@procsys.com> you wrote:
>  
>
>>    Any  issues with my Patches, SATA and clearing of bss section. 
>>Please update me.
>>    
>>
>
>I wrote:
>
>  
>
>>>Applied to u-boot-testing.
>>>      
>>>
>
>Did you test the code in the u-boot-testing  repository?  I  did  not
>receive any feedback from you (nor any form others).
>
>Best regards,
>
>Wolfgang Denk
>
>  
>