From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH: cmdcfg: 00/19] Introduce initial versions of new Command Config files.
Date: Tue, 12 Jun 2007 12:41:05 -0500 [thread overview]
Message-ID: <466EDAB1.8040601@freescale.com> (raw)
In-Reply-To: <20070612165624.78B3B352681@atlas.denx.de>
Wolfgang Denk wrote:
> In message <466EC4FB.9070706@freescale.com> you wrote:
>> #define CONFIG_CMD_AUTOSCRIPT CFG_CMD_AUTOSCRIPT
>>
>>>> ... ( repeat for each CONFIG_CMD_x )
>>> grrrghh....
>> It's still better than modifying dozens of source files!
>
> No, it's worse, as it would mean that such mess sticks forever.
Once every board header file has been converted to the new method, then you can remove all
that gunk from cmd_confdefs.h and update the .c files. Jon's approach requires you to
update the .c files twice - once now to add support for the new method, and again later to
remove support for the old method.
> Let's do it once, and right, even if it's a painful operation.
I don't think "#if (CONFIG_COMMANDS & CFG_CMD_AUTOSCRIPT) ||
defined(CONFIG_CMD_AUTOSCRIPT" is doing it right the first time.
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2007-06-12 17:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 23:56 [U-Boot-Users] [PATCH: cmdcfg: 00/19] Introduce initial versions of new Command Config files Jon Loeliger
2007-06-12 15:22 ` Timur Tabi
2007-06-12 15:59 ` Wolfgang Denk
2007-06-12 16:07 ` Jon Loeliger
2007-06-12 16:08 ` Timur Tabi
2007-06-12 16:56 ` Wolfgang Denk
2007-06-12 17:41 ` Timur Tabi [this message]
2007-06-12 17:33 ` Ben Warren
2007-07-03 22:45 ` Wolfgang Denk
2007-07-05 0:59 ` Jon Loeliger
2007-07-05 1:43 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466EDAB1.8040601@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox