From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Tue, 12 Jun 2007 12:41:05 -0500 Subject: [U-Boot-Users] [PATCH: cmdcfg: 00/19] Introduce initial versions of new Command Config files. In-Reply-To: <20070612165624.78B3B352681@atlas.denx.de> References: <20070612165624.78B3B352681@atlas.denx.de> Message-ID: <466EDAB1.8040601@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <466EC4FB.9070706@freescale.com> you wrote: >> #define CONFIG_CMD_AUTOSCRIPT CFG_CMD_AUTOSCRIPT >> >>>> ... ( repeat for each CONFIG_CMD_x ) >>> grrrghh.... >> It's still better than modifying dozens of source files! > > No, it's worse, as it would mean that such mess sticks forever. Once every board header file has been converted to the new method, then you can remove all that gunk from cmd_confdefs.h and update the .c files. Jon's approach requires you to update the .c files twice - once now to add support for the new method, and again later to remove support for the old method. > Let's do it once, and right, even if it's a painful operation. I don't think "#if (CONFIG_COMMANDS & CFG_CMD_AUTOSCRIPT) || defined(CONFIG_CMD_AUTOSCRIPT" is doing it right the first time. -- Timur Tabi Linux Kernel Developer @ Freescale