public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] command loads broken since a while
@ 2007-06-22 13:05 Wolfgang Grandegger
  0 siblings, 0 replies; only message in thread
From: Wolfgang Grandegger @ 2007-06-22 13:05 UTC (permalink / raw)
  To: u-boot

Hello,

recently, I realized that the U-Boot command "loads" is broken and the 
attached preliminary patch fixes it:

diff --git a/common/cmd_load.c b/common/cmd_load.c
index f63b8e8..2d9e0f0 100644
--- a/common/cmd_load.c
+++ b/common/cmd_load.c
@@ -240,12 +240,14 @@ read_record (char *buf, ulong len)
  			*p = c;
  		}

+#if 0
  	    /* Check for the console hangup (if any different from serial) */
  	    if (gd->jt[XF_getc] != getc) {
  		if (ctrlc()) {
  		    return (-1);
  		}
  	    }
+#endif
  	}

  	/* line too long - truncate */

The error sneaked in, when serial_getc was replaced with getc some time 
in the past. Can somebody tell me what the above code snippet is good 
for? I cannot see how to run the transfer over a line not being the 
console but maybe I have missed something.

Wolfgang.

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-06-22 13:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-22 13:05 [U-Boot-Users] command loads broken since a while Wolfgang Grandegger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox