public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Fabio Estevam <fabioestevam@yahoo.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx51evk: Provide a proper reset for the Ethernet PHY
Date: Fri, 20 Aug 2010 07:26:21 -0700 (PDT)	[thread overview]
Message-ID: <46828.21571.qm@web51007.mail.re2.yahoo.com> (raw)
In-Reply-To: <4C6E3D76.3040508@denx.de>

Hi Stefano,

--- On Fri, 8/20/10, Stefano Babic <sbabic@denx.de> wrote:
...

> 
> I know I am responsible for this usage, because I forget to
> add some
> accessors for the gpio pins - as I see your patch, I have
> sent a patch
> to support it. However, a direct access to registers using
> offsets is
> not allowed in u-boot. If we use some kind of accessors,
> your code will
> be easier to read it. Everything could be changed as
> (0X4000 --> gpio
> 46, if I am not wrong):
> 
> ??? udelay(200);
> ??? mxc_gpio_set(46);
> 
> What do you think ?

Yes, I agree. Do you plan to send a patch for mx51evk using this approach?

If you do, then I can re-submit my patch after your update.

Regards,

Fabio Estevam



      

  reply	other threads:[~2010-08-20 14:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19 17:28 [U-Boot] [PATCH] mx51evk: Provide a proper reset for the Ethernet PHY Fabio Estevam
2010-08-20  8:31 ` Stefano Babic
2010-08-20 14:26   ` Fabio Estevam [this message]
2010-08-20 14:39     ` Stefano Babic
2010-08-20 15:33       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46828.21571.qm@web51007.mail.re2.yahoo.com \
    --to=fabioestevam@yahoo.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox