From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 15/17] Create new fdt boardsetup command, fix bug parsing [] form of set values.
Date: Thu, 05 Jul 2007 06:36:52 -0400 [thread overview]
Message-ID: <468CC9C4.7060501@gmail.com> (raw)
In-Reply-To: <fa686aa40707042005y156778fegb222d9a5df72d33c@mail.gmail.com>
Grant Likely wrote:
> On 7/4/07, Jerry Van Baren <gvb.uboot@gmail.com> wrote:
>> @@ -62,17 +58,6 @@ int fdt_chosen(void *fdt, ulong initrd_start, ulong
>> initrd_end, int force)
>> return err;
>> }
>>
>> -#ifdef CONFIG_OF_BOARD_SETUP
>> - /*
>> - * ft_board_setup() sets various board-specific properties to
>> - * the proper values.
>> - *
>> - * STRICTLY SPEAKING, this is out of place, but it isn't clear
>> - * where a better place would be.
>> - */
>> - ft_board_setup(fdt, bd);
>> -#endif
>> -
>
> Wasn't this code just added in an earlier patch in this series? :-)
>
> Cheers,
> g.
Yes, I took two steps - one to make it work and one to do it right and
didn't go back and consolidate the two in the patches. Patch 15/17 adds
the "fdt boardsetup" command which allowed me to remove this ugly.
Best regards,
gvb
prev parent reply other threads:[~2007-07-05 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 1:21 [U-Boot-Users] [PATCH 15/17] Create new fdt boardsetup command, fix bug parsing [] form of set values Jerry Van Baren
2007-07-05 3:05 ` Grant Likely
2007-07-05 10:36 ` Jerry Van Baren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468CC9C4.7060501@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox