From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Thu, 05 Jul 2007 19:46:46 -0400 Subject: [U-Boot-Users] [PATCH 6/17] Reorganize and fix problems (returns) in the bootm command. In-Reply-To: <20070705193817.580D7353A64@atlas.denx.de> References: <20070705193817.580D7353A64@atlas.denx.de> Message-ID: <468D82E6.3020000@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <468D0E3D.3000308@freescale.com> you wrote: >> Jerry Van Baren wrote: >> > We've smashed our underpinnings by uncompressing linux over our >> > interrupt vectors before the checksum catches the problem. There is no >> > way back other than a reset. >> >> Can you include this explanation as a comment in the code at the exact point this occurs? > > Ummm... what exactly is not clear enough with this comment in > "common/cmd_bootm.c": > > /* > * We have reached the point of no return: we are going to > * overwrite all exception vector code, so we cannot easily > * recover from any failures any more... > */ > > ??? Do you need additional explanations? What should be added? > > Best regards, > > Wolfgang Denk Maybe if we enhanced the comment so it catches the eye of your average geek. Perhaps one of these: Of course, we would have to do #ifdef MALE around it... ;-) gvb (who missed the comment himself, the first time around)