[U-Boot-Users] [FIX] FDT bug - MPC83xx

[U-Boot-Users] [FIX] FDT bug - MPC83xx

[Michal Simek]

HI,

I look at FDT and I found small bug in cpu.c file

Signed-off-by: Michal Simek <monstr@monstr.eu>

Best regards,
Michal Simek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-fdt
Type: text/x-c
Size: 699 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070709/2f93e8df/attachment.bin 

[U-Boot-Users] [FIX] FDT bug - MPC83xx

[Kim Phillips]

On Mon, 09 Jul 2007 13:42:00 +0200 (CEST)
Michal Simek <Monstr@seznam.cz> wrote:

> HI,
> 
> I look at FDT and I found small bug in cpu.c file
> 
> Signed-off-by: Michal Simek <monstr@monstr.eu>

Hi Michal, gvb has already fixed this in his fdt branch on the fdt tree
on denx.de.  Please pull the fdt branch from the fdt tree.

Kim

p.s. gvb, I haven't gotten to review your patches yet, but will very
soon now.

[U-Boot-Users] [FIX] FDT bug - MPC83xx

[Jerry Van Baren]

Kim Phillips wrote:
> On Mon, 09 Jul 2007 13:42:00 +0200 (CEST)
> Michal Simek <Monstr@seznam.cz> wrote:
> 
>> HI,
>>
>> I look at FDT and I found small bug in cpu.c file
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
> 
> Hi Michal, gvb has already fixed this in his fdt branch on the fdt tree
> on denx.de.  Please pull the fdt branch from the fdt tree.

Hi Michal,

Just to tag onto Kim's reply, if you do
   $ git pull git://www.denx.de/git/u-boot-fdt fdt
you will pull my latest version into your repository.  If you are the 
cautious type, you can create a branch and pull into the branch before 
you pull it into your mainline.

Testing is appreciated!

> Kim
> 
> p.s. gvb, I haven't gotten to review your patches yet, but will very
> soon now.

Thanks, Michal & Kim,
gvb

[U-Boot-Users] [FIX] FDT bug - MPC83xx

[Michal Simek]

Hi,

> Hi Michal, gvb has already fixed this in his fdt branch on the fdt tree
> on denx.de.  Please pull the fdt branch from the fdt tree.

I looked at http://www.denx.de/cgi-bin/gitweb.cgi to Jerry's FDT repository to u-boot/u-boot-fdt.git]/ cpu / mpc83xx / cpu.c file
Lines are below. I don't see these changes.

Best regards,
Michal Simek

 437 #ifdef CONFIG_TSEC1
 438         {       "/" OF_SOC "/ethernet at 24000,
 439                 "mac-address",
 440                 fdt_set_eth0
 441         },
 442         {       "/" OF_SOC "/ethernet at 24000,
 443                 "local-mac-address",
 444                 fdt_set_eth0
 445         },
 446 #endif
 447 #ifdef CONFIG_TSEC2
 448         {       "/" OF_SOC "/ethernet at 25000,
 449                 "mac-address",
 450                 fdt_set_eth1
 451         },
 452         {       "/" OF_SOC "/ethernet at 25000,
 453                 "local-mac-address",
 454                 fdt_set_eth1
 455         },
 456 #endif

[U-Boot-Users] [FIX] FDT bug - MPC83xx

[Jerry Van Baren]

Michal Simek wrote:
> Hi,
> 
>> Hi Michal, gvb has already fixed this in his fdt branch on the fdt tree
>> on denx.de.  Please pull the fdt branch from the fdt tree.
> 
> I looked at http://www.denx.de/cgi-bin/gitweb.cgi to Jerry's FDT repository to u-boot/u-boot-fdt.git]/ cpu / mpc83xx / cpu.c file
> Lines are below. I don't see these changes.
> 
> Best regards,
> Michal Simek

Hi Michal,

The gitweb display is the "master" branch, you need to scroll to the 
bottom of the page and select the "fdt" branch (under the heading 
"heads") to see the changes you are interested in.

<http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-fdt.git;a=shortlog;h=fdt>

It is the top patch in the list.  (Unfortunately the diff is suboptimal 
for reading because of the way diff handled the repeated pattern.)
<http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-fdt.git;a=commitdiff;h=a565569208b048fb973751389487a744e3e31e2f>

Actual file:
<http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-fdt.git;a=blob;f=cpu/mpc83xx/cpu.c;h=455b7a755d7521461f3db2e2ceb9344d7712d687;hb=a565569208b048fb973751389487a744e3e31e2f#l405>

gvb

[U-Boot-Users] [FIX] FDT bug - MPC83xx

[Michal Simek]

Hi,
thanks for explanation.
Do you have any documentation about FDT? I would like to test it.
I have proprietary board with MPC8343 like a testing platform and if is useful for Microblaze, I will try to port it.

Best regards,
Michal

> Hi,
> 
>> Hi Michal, gvb has already fixed this in his fdt branch on the fdt tree
>> on denx.de.  Please pull the fdt branch from the fdt tree.
> 
> I looked at http://www.denx.de/cgi-bin/gitweb.cgi to Jerry's FDT repository to
u-boot/u-boot-fdt.git]/ cpu / mpc83xx / cpu.c file
> Lines are below. I don't see these changes.
> 
> Best regards,
> Michal Simek

Hi Michal,

The gitweb display is the "master" branch, you need to scroll to the 
bottom of the page and select the "fdt" branch (under the heading 
"heads") to see the changes you are interested in.

<http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-fdt.git;a=shortlog;h=fdt>

It is the top patch in the list.  (Unfortunately the diff is suboptimal 
for reading because of the way diff handled the repeated pattern.)
<http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-fdt.git;a=commitdiff;h=a565569208b048fb973751389487a744e3e31e2f>

Actual file:
<http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-fdt.git;a=blob;f=cpu/mpc83xx/cpu.c;h=455b7a755d7521461f3db2e2ceb9344d7712d687;hb=a565569208b048fb973751389487a744e3e31e2f#l405>

gvb

[U-Boot-Users] [FIX] FDT bug - MPC83xx

[Jerry Van Baren]

Michal Simek wrote:
> Hi,
> thanks for explanation.
> Do you have any documentation about FDT? I would like to test it.
> I have proprietary board with MPC8343 like a testing platform and if
> is useful for Microblaze, I will try to port it.
> 
> Best regards,
> Michal

Documentation? We don't need no steeenkin' documentation!

I'm NOT a fdt expert.  I simply stood on the experts' shoulders.  To be 
specific, I took David Gibson's libfdt interface library and created a 
"fdt" command on top of that.  As part of that, I adapted some board, 
etc, munging that was done as part of the "bootm" command to use David's 
libfdt as well, instead of the older set of utilities (the older utility 
routines have a kinda funky interface).

If you look at the custodians' page
   <http://www.denx.de/wiki/UBoot/Custodians>
you will see a pointer to my Work In Progress page
   <http://www.denx.de/wiki/UBoot/UBootFdtInfo>

I've just added a background section that is a lot of jump-off links for 
more information.
<http://www.denx.de/wiki/view/UBoot/UBootFdtInfo#Background_Information_on_Flatte>

Note that it's a wiki -- please add improvements!

gvb