From: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] pciauto_setup_device bars_num fix
Date: Thu, 26 Jul 2007 10:27:12 +0900 [thread overview]
Message-ID: <46A7F870.6060100@necel.com> (raw)
In-Reply-To: <11853449333700-git-send-email-Ed.Swarthout@freescale.com>
Ed Swarthout wrote:
> Passing bars_num=0 to pciauto_setup_device should assign no bars.
>
> Signed-off-by: Ed Swarthout <Ed.Swarthout@freescale.com>
Indeed. This patch works fine on our MIPS target.
Acked-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
> ---
> drivers/pci_auto.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci_auto.c b/drivers/pci_auto.c
> index a3c609b..2378553 100644
> --- a/drivers/pci_auto.c
> +++ b/drivers/pci_auto.c
> @@ -94,7 +94,7 @@ void pciauto_setup_device(struct pci_controller *hose,
> pci_hose_read_config_dword(hose, dev, PCI_COMMAND, &cmdstat);
> cmdstat = (cmdstat & ~(PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) | PCI_COMMAND_MASTER;
>
> - for (bar = PCI_BASE_ADDRESS_0; bar <= PCI_BASE_ADDRESS_0 + (bars_num*4); bar += 4) {
> + for (bar = PCI_BASE_ADDRESS_0; bar < PCI_BASE_ADDRESS_0 + (bars_num*4); bar += 4) {
> /* Tickle the BAR and get the response */
> pci_hose_write_config_dword(hose, dev, bar, 0xffffffff);
> pci_hose_read_config_dword(hose, dev, bar, &bar_response);
prev parent reply other threads:[~2007-07-26 1:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 6:28 [U-Boot-Users] [PATCH] pciauto_setup_device bars_num fix Ed Swarthout
2007-07-26 1:27 ` Shinya Kuribayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A7F870.6060100@necel.com \
--to=shinya.kuribayashi@necel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox