From: Ben Warren <bwarren@qstreams.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/2] Add support for SBC8641D
Date: Tue, 31 Jul 2007 11:35:51 -0400 [thread overview]
Message-ID: <46AF56D7.4090500@qstreams.com> (raw)
In-Reply-To: <1185894029.28101.21.camel@server>
Joe Hamman wrote:
<snip>
> +
> +/*
> + * Environment Configuration
> + */
> +
> +/* The mac addresses for all ethernet interface */
> +#if defined(CONFIG_TSEC_ENET)
> +#define CONFIG_ETHADDR 00:E0:0C:00:00:01
> +#define CONFIG_ETH1ADDR 00:E0:0C:00:01:FD
> +#define CONFIG_ETH2ADDR 00:E0:0C:00:02:FD
> +#define CONFIG_ETH3ADDR 00:E0:0C:00:03:FD
> +#endif
>
If you're going to default MAC addresses (which IMHO is a bad idea),
they should be private ones (i.e. bit 41 is set). The ones you've
listed belong to somebody (or more likely some faceless organization).
It would be better to leave these out and make the user program them at
board bring-up.
regards,
Ben
next prev parent reply other threads:[~2007-07-31 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 15:00 [U-Boot-Users] [PATCH 2/2] Add support for SBC8641D Joe Hamman
2007-07-31 15:35 ` Ben Warren [this message]
2007-07-31 17:18 ` Joe Hamman
2007-07-31 17:57 ` Jon Loeliger
2007-07-31 18:38 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2007-08-09 20:11 Joe Hamman
2007-08-09 21:43 ` Wolfgang Denk
2007-08-10 19:58 ` Jon Loeliger
2007-08-10 21:27 ` Joe Hamman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AF56D7.4090500@qstreams.com \
--to=bwarren@qstreams.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox