[U-Boot-Users] [PATCH: u-boot-fdt] Improve error print messages.

Michal Simek
2007-08-08T13:38:29Z

HI,

>Undefine CONFIG_OF_FLAT_TREE - it and CONFIG_OF_LIBFDT are mutually
>exclusive. That is The Old Way, CONFIG_OF_LIBFDT is The New Way. The
>following is the starting point. CONFIG_OF_BOARD_SETUP is most likely
>necessary, CONFIG_OF_HAS_BD_T is either necessary or A Good Thing, and
>CONFIG_OF_HAS_UBOOT_ENV is optional.
>
>/* pass open firmware flat tree */
>#define CONFIG_OF_LIBFDT 1
>#undef CONFIG_OF_FLAT_TREE
>#define CONFIG_OF_BOARD_SETUP 1
>#define CONFIG_OF_HAS_BD_T 1
>#define CONFIG_OF_HAS_UBOOT_ENV 1

I changed setting but I have problem with compilation.

/* pass open firmware flat tree */
-#define CONFIG_OF_FLAT_TREE 1
+#define CONFIG_OF_LIBFDT 1
+#undef CONFIG_OF_FLAT_TREE
#define CONFIG_OF_BOARD_SETUP 1
+#define CONFIG_OF_HAS_BD_T 1
+#define CONFIG_OF_HAS_UBOOT_ENV

MPC8349 has compilation problem.

common/libcommon.a(cmd_bootm.o): In function `do_bootm_linux':
/tmp/1/u-boot-fdt.git/common/cmd_bootm.c:978: undefined reference to `ft_board_setup'
common/libcommon.a(cmd_fdt.o): In function `do_fdt':
/tmp/1/u-boot-fdt.git/common/cmd_fdt.c:300: undefined reference to `ft_board_setup'
make: *** [u-boot] Error 1

I tried to change board specific file. Part of patch is below. And function ft_get_prop isn't available. Function ft_get_prop is in common/ft_build.c and this file is in CONFIG_OF_FLAT_TREE choice. What can I do with this?

--- a/board/mpc8349emds/mpc8349emds.c
+++ b/board/mpc8349emds/mpc8349emds.c
@@ -584,7 +584,7 @@ U_BOOT_CMD(
);
#endif /* if defined(CONFIG_DDR_ECC) && defined(CONFIG_DDR_ECC_CMD) */

-#if defined(CONFIG_OF_FLAT_TREE) && defined(CONFIG_OF_BOARD_SETUP)
+#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
void
ft_board_setup(void *blob, bd_t *bd)
{

I can try fdt on PQ3 (MPC8560 and EP8548).Is it better choise than PQ II Pro?

Best regards,
Michal Simek