From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [ARM] TI DaVinci support, 2nd attempt [0/5]
Date: Tue, 07 Aug 2007 19:04:19 +0200 [thread overview]
Message-ID: <46B8A613.5050401@googlemail.com> (raw)
In-Reply-To: <Pine.LNX.4.64ksi.0708061905150.30478@home-gw.koi8.net>
ksi at koi8.net wrote:
> Signed-off-by: Sergey Kubushyn <ksi@koi8.net>
>
> Here it is.
>
> Changes:
>
> - Split into separate board directories
> - Removed changes to MTD_DEBUG (or whatever it's called)
> - New CONFIG_CMD party line followed
> - Some cosmetic fixes, cleanup etc.
> - Patches against the latest U-Boot tree as of now.
Many thanks!
> Unfortunately it won't compile because of that BIOS emulator or what it
> is...
I just sent a hackish patch to be able to at least compile.
With this, some comments to your recent patches:
1) As with your first set of patches, I can't get patch 2/5 and 4/5
get apply cleanly. I get rejects needing manual resolve for everything
modifying already existing files. All files/patches adding new files
apply cleanly.
2) The net files don't compile because they need new style config option
#if defined(CONFIG_CMD_NET) ...
3) Schmoogie config needs a #undef CONFIG_CMD_EEPROM instead of a #define
4) With schmoogie config, schmoogie/dv_board.c fails linking because
of missing forceenv(). E.g. in exports.h this is clamped by #ifdef
CONFIG_HAS_UID. So I think misc_init_r() in all three dv_board.c need
anything similiar.
I will send my updated versions of your patches for reference as
answers to the individual patch mails. No, I don't want to steal
anything. I want to help. They resolve 1) - 3), so only (4) is open.
Feel free to send them again with your Signed-off-by, to ignore them,
or use them for update. You mentioned that you are short of time, so
hopefully we can avoid to invent the wheel two times and reuse stuff
already fixed.
For me, then everything else looks okay ;) So I think resolving (4)
will be the hopefully final version then.
Best regards
Dirk
next prev parent reply other threads:[~2007-08-07 17:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 2:11 [U-Boot-Users] [ARM] TI DaVinci support, 2nd attempt [0/5] ksi at koi8.net
2007-08-07 17:04 ` Dirk Behme [this message]
2007-08-07 17:09 ` ksi at koi8.net
2007-08-07 17:40 ` Dirk Behme
2007-08-07 18:02 ` ksi at koi8.net
-- strict thread matches above, loose matches on Subject: below --
2007-08-07 2:13 [U-Boot-Users] [ARM] TI DaVinci support, 2nd attempt [1/5] ksi at koi8.net
[not found] ` <5CBE65F7D9232C47861CB09B0954861C2FD8F8@MAIL.infinitychannel.local>
2007-08-07 2:22 ` [U-Boot-Users] [ARM] TI DaVinci support, 2nd attempt [0/5] Zach Sadecki
2007-08-07 4:43 ` ksi at koi8.net
2007-08-07 12:52 ` Zach Sadecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B8A613.5050401@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox