From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Trimarchi Date: Sun, 19 Aug 2007 05:37:27 +0200 Subject: [U-Boot-Users] FIX: dataflash.c In-Reply-To: <20070819005029.7D7AD246C5@gemini.denx.de> References: <20070819005029.7D7AD246C5@gemini.denx.de> Message-ID: <46C7BAF7.3080905@gandalf.sssup.it> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > I hereby reject this patch. > > Replacing a configuration option by a hardwired constant which is > probably wrong on most of the boards is definitely a Bad Thing. > > ok > Also, you did not even mention what sort of problem you are trying to > fix. > > It fix an invalid use of a pointer and and invalid use of an array. regards michael -------------- next part -------------- A non-text attachment was scrubbed... Name: dataflash.at41.patch Type: text/x-patch Size: 1038 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20070819/345eeafe/attachment.bin