public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] omap2420h4 error
Date: Mon, 20 Aug 2007 07:09:05 +0200	[thread overview]
Message-ID: <46C921F1.5040602@googlemail.com> (raw)
In-Reply-To: <20070819205356.9FA4624043@gemini.denx.de>

Wolfgang Denk wrote:
> In message <46C8A2DE.3090500@gmail.com> you wrote:
> 
>>>Proposal to fix this is to remove unused file board/omap2420h4/flash.c 
>>>and remove calls of flash_probe()/omap2420h4 #ifdefs in env_flash.c. 
>>>However, not sure if this is correct.
>>
>>I think a more details solution is required for all omap2 SDPs.. the
>>newer H4's seem to have larger range of device supports and i am looking
>>to work towards a common code base for all SDP platforms(2430,3430
>>etc).. something like board/omap-common directory.. i have started a bit
>>on it.. but it will take a bit of time before i can get it out as
>>working patches..
> 
> 
> Well, I think these are two different things:
> 
> Dirk is proposing a fix for the current tree, i. e. for the next
> release to make the board build.
> 
> You are proposing a more general solution, which involves bigger
> changes than just a bug fix, and thus has to wait for the next merge
> window.
> 
> That means we need both...

Yes, thanks for clarification.

What's about this regarding the first step, make board build for next
release?

--

Fix compilation error for omap2420h4_config. omap2420h4 switched to
cfi, so remove old (already disabled) flash.c and flash_probe() calls
in env_flash.c.

Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: omap2420h4_error_fix.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070820/d30873f8/attachment.txt 

  reply	other threads:[~2007-08-20  5:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-19 17:05 [U-Boot-Users] omap2420h4 error Dirk Behme
2007-08-19 20:06 ` Nishanth Menon
2007-08-19 20:53   ` Wolfgang Denk
2007-08-20  5:09     ` Dirk Behme [this message]
2007-08-29  0:02       ` [U-Boot-Users] [PATCH] " Wolfgang Denk
2007-08-19 20:24 ` [U-Boot-Users] " Woodruff, Richard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C921F1.5040602@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox