From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Mon, 20 Aug 2007 07:09:05 +0200 Subject: [U-Boot-Users] [PATCH] omap2420h4 error In-Reply-To: <20070819205356.9FA4624043@gemini.denx.de> References: <20070819205356.9FA4624043@gemini.denx.de> Message-ID: <46C921F1.5040602@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <46C8A2DE.3090500@gmail.com> you wrote: > >>>Proposal to fix this is to remove unused file board/omap2420h4/flash.c >>>and remove calls of flash_probe()/omap2420h4 #ifdefs in env_flash.c. >>>However, not sure if this is correct. >> >>I think a more details solution is required for all omap2 SDPs.. the >>newer H4's seem to have larger range of device supports and i am looking >>to work towards a common code base for all SDP platforms(2430,3430 >>etc).. something like board/omap-common directory.. i have started a bit >>on it.. but it will take a bit of time before i can get it out as >>working patches.. > > > Well, I think these are two different things: > > Dirk is proposing a fix for the current tree, i. e. for the next > release to make the board build. > > You are proposing a more general solution, which involves bigger > changes than just a bug fix, and thus has to wait for the next merge > window. > > That means we need both... Yes, thanks for clarification. What's about this regarding the first step, make board build for next release? -- Fix compilation error for omap2420h4_config. omap2420h4 switched to cfi, so remove old (already disabled) flash.c and flash_probe() calls in env_flash.c. Signed-off-by: Dirk Behme -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: omap2420h4_error_fix.txt Url: http://lists.denx.de/pipermail/u-boot/attachments/20070820/d30873f8/attachment.txt