[U-Boot-Users] PS1 environment variable

[U-Boot-Users] PS1 environment variable

[Timur Tabi]

I see in hush.c some code to set the prompt from the PS1 environment variable, 
but I can't find any documentation on this feature, nor can I figure out how 
to make it work.  Can someone tell me how?

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

[U-Boot-Users] PS1 environment variable

[Wolfgang Denk]

In message <46D346D0.9060705@freescale.com> you wrote:
> I see in hush.c some code to set the prompt from the PS1 environment variable, 
> but I can't find any documentation on this feature, nor can I figure out how 
> to make it work.  Can someone tell me how?

If you had a look at the code, you should notice  that  all  relevant
parts  of  the  code  are  between  "#ifndef __U_BOOT__" ... "#endif"
pairs.

In other words, this is not available in U-Boot.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The more we disagree, the more chance there is that at least  one  of
us is right.

[U-Boot-Users] PS1 environment variable

[Timur Tabi]

Wolfgang Denk wrote:
> In message <46D346D0.9060705@freescale.com> you wrote:
>> I see in hush.c some code to set the prompt from the PS1 environment variable, 
>> but I can't find any documentation on this feature, nor can I figure out how 
>> to make it work.  Can someone tell me how?
> 
> If you had a look at the code, you should notice  that  all  relevant
> parts  of  the  code  are  between  "#ifndef __U_BOOT__" ... "#endif"
> pairs.
> 
> In other words, this is not available in U-Boot.

Why is there U-Boot code that is not available in U-Boot?

(and for the record, I did look at the code and I did notice that, and I found 
that #ifdef so odd I figured I'd better ask).

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

[U-Boot-Users] PS1 environment variable

[Wolfgang Denk]

In message <46D34AF4.3030808@freescale.com> you wrote:
>
> > If you had a look at the code, you should notice  that  all  relevant
> > parts  of  the  code  are  between  "#ifndef __U_BOOT__" ... "#endif"
> > pairs.
> > 
> > In other words, this is not available in U-Boot.
> 
> Why is there U-Boot code that is not available in U-Boot?

It's not U-Bot code, it's hush code. We "imported" the hus shell from
BusyBox, and to keep it in sync with any changes or improvements done
in BusyBox' version it is a Good Idea (TM) to change the file only to
the minimum extend needed to make it work.

> (and for the record, I did look at the code and I did notice that, and I found 
> that #ifdef so odd I figured I'd better ask).

It's not odd at all. Actually it's even kind of documented as item  2
of   the  Coding  Style  document:  "Source  files  originating  from
different projects (for example the MTD subsystem or the  hush  shell
code  from  the BusyBox project) may, after careful consideration, be
exempted from these rules. For such files, the original coding  style
may  be  kept to ease subsequent migration to newer versions of those
sources."

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Everyting looks interesting until you do it. Then you find it's  just
another job.                     - Terry Pratchett, _Moving Pictures_

[U-Boot-Users] PS1 environment variable

[Timur Tabi]

Wolfgang Denk wrote:

> It's not U-Bot code, it's hush code. We "imported" the hus shell from
> BusyBox, and to keep it in sync with any changes or improvements done
> in BusyBox' version it is a Good Idea (TM) to change the file only to
> the minimum extend needed to make it work.

Ok.  Would you accept a patch that enabled this particular feature?

We have lots of machines in our lab, and I frequently have multiple 
terminal windows open.  I sometimes can't tell which machine I'm logged
into.  Being able to specify a prompt in an environment variable would 
solve that problem for me.

[U-Boot-Users] PS1 environment variable

[Wolfgang Denk]

In message <46D36EDF.1060703@freescale.com> you wrote:
> 
> Ok.  Would you accept a patch that enabled this particular feature?

Yes, of course. You might find that this is not a  trivial  thing  to
add.  The  concept  variables and the relations of U-Boot envrionment
variables, shell variables, and shell environment variables is a  bit
tricky.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If it went on at this rate, in several billion  years  he'd  be  rich
beyond his wildest dreams!            - Terry Pratchett, _Soul Music_