U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Sieka <tur@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH/RFC] mpc5200: switch to CONFIG_OF_LIBFDT
Date: Mon, 03 Sep 2007 22:23:08 +0200	[thread overview]
Message-ID: <46DC6D2C.6020000@semihalf.com> (raw)
In-Reply-To: <fa686aa40708311039u24662e81q45094efb401d9e5a@mail.gmail.com>

Grant Likely wrote:
[...]
>>>> -#if defined(CONFIG_OF_FLAT_TREE)
>>>> -#include <ft_build.h>
>>>> -#endif
>>>> +#ifdef CONFIG_OF_LIBFDT
>>>> +#include <libfdt.h>
>>>> +#include <libfdt_env.h>
>>>> +#include <fdt_support.h>
>>> ditto.
>>>
>>>> +#endif /* CONFIG_OF_LIBFDT */
>>> do the includes need such protection?
>> There are a number of 5200 boards that haven't been migrated to
>> support fdt yet, so I left the protection in.  I suppose it can be
>> removed.
> 
> Ignore this comment; I was on crack.. Of course the protections are
> not needed for the board specific code.  I'll fix.

Could similar protections around ft_board_setup() definition in 
board-specific code be removed as well? I'm thinking about:

#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
void ft_board_setup(void *blob, bd_t *bd)
{
         ft_cpu_setup(blob, bd);
}
#endif /* defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) */


Regards,
Bartlomiej

  reply	other threads:[~2007-09-03 20:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-30 18:20 [U-Boot-Users] [PATCH/RFC] mpc5200: switch to CONFIG_OF_LIBFDT Grant Likely
2007-08-30 21:57 ` Kim Phillips
2007-08-30 22:33   ` Grant Likely
2007-08-31 17:39     ` Grant Likely
2007-09-03 20:23       ` Bartlomiej Sieka [this message]
2007-09-03 21:50         ` Grant Likely
2007-09-03 20:36 ` Bartlomiej Sieka
2007-09-03 21:47   ` Grant Likely
2007-09-03 21:59     ` Jerry Van Baren
2007-09-03 22:09       ` Grant Likely
2007-09-03 22:40         ` Jerry Van Baren
2007-09-03 22:55           ` Grant Likely
2007-09-04  0:18             ` Jerry Van Baren
2007-09-04  3:09               ` Grant Likely
2007-09-04  4:14                 ` Grant Likely
2007-09-04 12:39                 ` Jerry Van Baren
2007-09-04 14:46                   ` Jon Loeliger
2007-09-04 14:48                     ` Jon Loeliger
2007-09-04 14:48                     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46DC6D2C.6020000@semihalf.com \
    --to=tur@semihalf.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox