From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerry Van Baren <gerald.vanbaren@smiths-aerospace.com>
Date: Thu, 06 Sep 2007 09:54:43 -0400
Subject: [U-Boot-Users] fdt command: can't set a value-less property
In-Reply-To: <46E0043F.6070906@semihalf.com>
References: <46E0043F.6070906@semihalf.com>
Message-ID: <46E006A3.6090406@smiths-aerospace.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Bartlomiej Sieka wrote:
> Hello,
> 
> I'm playing with the fdt command in recent (60174746) U-Boot and I can't
> set a property that does not have a value.
> Documentation/powerpc/booting-without-of.txt" says "A property can have
> a value or not.", and fdt help suggests the same:
> fdt set    <path> <prop> [<val>]    - Set <property> [to <val>]
> 
> However, I am getting:
> 
> => fdt mknode / testnode
> => fdt list /testnode
> testnode {
> };
> => fdt set /testnode testprop
> Usage:
> fdt     - flattened device tree utility commands
> 
> => fdt list /testnode
> testnode {
> };
> 
> Setting a property with value works:
> 
> => fdt set /testnode testprop "testvalue"
> => fdt list /testnode
> testnode {
>          testprop=""testvalue"";
> };
> 
> Am I doing something wrong, or is it a bug?
> 
> Regards,
> Bartlomiej

Hi Bartlomiej,

That looks like a bug.  The cmd_fdt.c parser looks like it is insisting 
on a value (looking for three parameters to the "fdt set" subcommand).

I have not looked at the code to confirm the above hypothesis yet...

Best regards,
gvb