public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bartlomiej Sieka <tur@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] fdt command: can't set a value-less property
Date: Thu, 06 Sep 2007 17:15:17 +0200	[thread overview]
Message-ID: <46E01985.8090000@semihalf.com> (raw)
In-Reply-To: <46E006A3.6090406@smiths-aerospace.com>

Jerry Van Baren wrote:
> Bartlomiej Sieka wrote:
>> Hello,
>>
>> I'm playing with the fdt command in recent (60174746) U-Boot and I can't
>> set a property that does not have a value.
[...]
>> Am I doing something wrong, or is it a bug?
[...]>
> That looks like a bug.  The cmd_fdt.c parser looks like it is insisting 
> on a value (looking for three parameters to the "fdt set" subcommand).
> 
> I have not looked at the code to confirm the above hypothesis yet...
> 
> Best regards,
> gvb

Hi Jerry,

Thanks for a quick reply.

I've got a few comments after playing with fdt commands a little bit 
more. They concern the help message of "fdt move", which says:
fdt move   <fdt> <newaddr> <length> - Copy the fdt to <addr>

And the comments are:
- <fdt> -> <addr> (to be in sync with "fdt addr" description)
- <length> -> [<length>]
- Copy the fdt to <addr> -> Copy the fdt to <newaddr>
- to me, it's not clear from the description that this command will make 
the blob at the new location the "active" one.

Does the above make sense? If yes, it might be a good idea to update the 
help message while working on the "fdt set" issue.

Regards,
Bartlomiej

  reply	other threads:[~2007-09-06 15:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-06 13:44 [U-Boot-Users] fdt command: can't set a value-less property Bartlomiej Sieka
2007-09-06 13:54 ` Jerry Van Baren
2007-09-06 15:15   ` Bartlomiej Sieka [this message]
2007-09-06 15:20     ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E01985.8090000@semihalf.com \
    --to=tur@semihalf.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox