From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Thu, 06 Sep 2007 11:20:26 -0400 Subject: [U-Boot-Users] fdt command: can't set a value-less property In-Reply-To: <46E01985.8090000@semihalf.com> References: <46E0043F.6070906@semihalf.com> <46E006A3.6090406@smiths-aerospace.com> <46E01985.8090000@semihalf.com> Message-ID: <46E01ABA.6010002@smiths-aerospace.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Bartlomiej Sieka wrote: > Jerry Van Baren wrote: >> Bartlomiej Sieka wrote: >>> Hello, >>> >>> I'm playing with the fdt command in recent (60174746) U-Boot and I can't >>> set a property that does not have a value. > [...] >>> Am I doing something wrong, or is it a bug? > [...]> >> That looks like a bug. The cmd_fdt.c parser looks like it is >> insisting on a value (looking for three parameters to the "fdt set" >> subcommand). >> >> I have not looked at the code to confirm the above hypothesis yet... >> >> Best regards, >> gvb > > Hi Jerry, > > Thanks for a quick reply. > > I've got a few comments after playing with fdt commands a little bit > more. They concern the help message of "fdt move", which says: > fdt move - Copy the fdt to > > And the comments are: > - -> (to be in sync with "fdt addr" description) > - -> [] > - Copy the fdt to -> Copy the fdt to > - to me, it's not clear from the description that this command will make > the blob at the new location the "active" one. > > Does the above make sense? If yes, it might be a good idea to update the > help message while working on the "fdt set" issue. > > Regards, > Bartlomiej Agreed, the help text should be improved to be more specific, less confusing, and its accuracy should be verified. Best regards, gvb