From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Thu, 20 Sep 2007 19:15:40 -0700 Subject: [U-Boot-Users] PATCH - Fix oob data copied into supplied buffer In-Reply-To: References: <46F30F3D.6070801@boundarydevices.com> Message-ID: <46F3294C.2030206@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de ksi at koi8.net wrote: > On Thu, 20 Sep 2007, Troy Kisky wrote: > > This doesn't look right to me. > > First chunk fixes a minor spelling error. Then I can't understand why > introduce a new variable. Everything works fine with existing structures > and > it's been like this for ages, both in Linux kernel and U-Boot. > If you look at the kernel, you'll see that oobavail is set there the way I did it. The other bug doesn't show up unless you have multiple oobfree groups. The new variable is used when reading or writing pages that an initial program loader reads. It's purpose is to correct pages without using a bad block table. I'll submit that code if this is approved. Troy