public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [MIPS] Fix toolchain restriction for little endian build
@ 2007-09-24 15:44 Shinya Kuribayashi
  2007-09-24 20:44 ` Wolfgang Denk
  0 siblings, 1 reply; 2+ messages in thread
From: Shinya Kuribayashi @ 2007-09-24 15:44 UTC (permalink / raw)
  To: u-boot

Fix ENDIANNESS condition to allow gcc toolchains other than ELDK.

Signed-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
---

 cpu/mips/config.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cpu/mips/config.mk b/cpu/mips/config.mk
index b29986e..1a4e800 100644
--- a/cpu/mips/config.mk
+++ b/cpu/mips/config.mk
@@ -29,7 +29,7 @@ else \
 	echo "-march=4kc -mtune=4kc"; \
 fi)
 
-ifneq (,$(findstring 4KCle,$(CROSS_COMPILE)))
+ifneq (,$(shell $(CC) -dumpmachine |grep 'mips.*el-.*'))
 ENDIANNESS = -EL
 else
 ENDIANNESS = -EB

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot-Users] [MIPS] Fix toolchain restriction for little endian build
  2007-09-24 15:44 [U-Boot-Users] [MIPS] Fix toolchain restriction for little endian build Shinya Kuribayashi
@ 2007-09-24 20:44 ` Wolfgang Denk
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2007-09-24 20:44 UTC (permalink / raw)
  To: u-boot

Dear Shinya Kuribayashi,

in message <46F7DB47.8030706@ruby.dti.ne.jp> you wrote:
> Fix ENDIANNESS condition to allow gcc toolchains other than ELDK.
> 
> Signed-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>

Thanks you very much for your patch.

> -ifneq (,$(findstring 4KCle,$(CROSS_COMPILE)))
> +ifneq (,$(shell $(CC) -dumpmachine |grep 'mips.*el-.*'))
>  ENDIANNESS = -EL
>  else
>  ENDIANNESS = -EB

I'm afraid I don't understand how this is supposed to work.
For example, I get this using ELDK 4.x:

	-> export CROSS_COMPILE=mips_4KC-
	-> mips_4KC-gcc -dumpmachine
	mips-linux
	-> export CROSS_COMPILE=mips_4KCle-
	-> mips_4KCle-gcc -dumpmachine
	mips-linux
	-> 

So this change might work with other toolchains (I'm not sure if it
does), but it definitely breaks ELDK support.

Am I missing something?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A day without sunshine is like night.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-09-24 20:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-24 15:44 [U-Boot-Users] [MIPS] Fix toolchain restriction for little endian build Shinya Kuribayashi
2007-09-24 20:44 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox