public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/7] pinctrl: mscc: Add gpio and pinctrl for Jaguar2 SOC family
Date: Wed, 9 Jan 2019 17:57:33 +0100	[thread overview]
Message-ID: <46fe00ad-8726-12bc-e225-2dde7dd5e263@gmail.com> (raw)
In-Reply-To: <20190109082148.f7nzg7imc5te26gk@soft-dev3.microsemi.net>



Am 09.01.19 um 09:21 schrieb Horatiu Vultur:
> Hi Daniel,
> 
> First, thank you for all the feedback.
> 
> I have created a new patch series that will fix the issue that you
> addressed bellow but the fix it would not use compatible string, because
> that presume that I need to change the other pinctrl-drivers(ocelot, luton).
> I was thinking if it is OK the way I have done in v3 and then create a
> new patch series specific for fixing pinctrl. Similar with the issue
> that I have for sysreset driver.

I didn't expect that you select the registers via compatible strings in
the pinctrl driver because you effectively have three drivers and a
common driver core. Your v3 variant is perfect. The compatible string
method makes sense for drivers that support more than one SoC. The
sysreset driver could be an example.

-- 
- Daniel

  reply	other threads:[~2019-01-09 16:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 13:02 [U-Boot] [PATCH v2 0/7] MSCC: Add Jaguar2 SOC family Horatiu Vultur
2019-01-07 13:02 ` [U-Boot] [PATCH v2 1/7] pinctrl: mscc: Add gpio and pinctrl for " Horatiu Vultur
2019-01-07 19:38   ` Daniel Schwierzeck
2019-01-08  8:00     ` Horatiu Vultur
2019-01-08 16:12       ` Daniel Schwierzeck
2019-01-09  8:21         ` Horatiu Vultur
2019-01-09 16:57           ` Daniel Schwierzeck [this message]
2019-01-07 13:02 ` [U-Boot] [PATCH v2 2/7] MSCC: Add support " Horatiu Vultur
2019-01-07 20:12   ` Daniel Schwierzeck
2019-01-07 13:02 ` [U-Boot] [PATCH v2 3/7] MSCC: Add device tree for Jaguar2 board Horatiu Vultur
2019-01-07 13:02 ` [U-Boot] [PATCH v2 4/7] MSCC: Add device tree for Jaguar2-48 board Horatiu Vultur
2019-01-07 13:02 ` [U-Boot] [PATCH v2 5/7] MSCC: add device tree for Serval2 board Horatiu Vultur
2019-01-07 13:02 ` [U-Boot] [PATCH v2 6/7] MSCC: Add board support for Jaguar2 SOC family Horatiu Vultur
2019-01-07 20:13   ` Daniel Schwierzeck
2019-01-07 13:02 ` [U-Boot] [PATCH v2 7/7] MSCC: Add sysreset driver " Horatiu Vultur
2019-01-07 20:11   ` Daniel Schwierzeck
2019-01-08  7:51     ` Horatiu Vultur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46fe00ad-8726-12bc-e225-2dde7dd5e263@gmail.com \
    --to=daniel.schwierzeck@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox