From: Vlad Lungu <vlad@comsys.ro>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Off-by-two bug when relocating GOT
Date: Thu, 04 Oct 2007 20:45:08 +0300 [thread overview]
Message-ID: <470526A4.40903@comsys.ro> (raw)
The first two entries are skipped but the number of relocated entries
is not adjusted; as a result, the first __u_boot_cmd_* structure is
smashed and no commands can be issued.
Signed-off-by: Vlad Lungu <vlad@comsys.ro>
---
cpu/mips/start.S | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/cpu/mips/start.S b/cpu/mips/start.S
index e91e213..1e5b302 100644
--- a/cpu/mips/start.S
+++ b/cpu/mips/start.S
@@ -349,6 +349,7 @@ in_ram:
/* Now we want to update GOT.
*/
lw t3, -4(t0) /* t3 <-- num_got_entries */
+ sub t3,2 /* If skipping two entries, adjust length*/
addi t4, gp, 8 /* Skipping first two entries. */
li t2, 2
1:
--
1.5.2.2
next reply other threads:[~2007-10-04 17:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 17:45 Vlad Lungu [this message]
2007-10-05 3:58 ` [U-Boot-Users] [PATCH] Off-by-two bug when relocating GOT Shinya Kuribayashi
2007-10-05 10:39 ` Vlad Lungu
2007-10-05 20:18 ` Thomas Lange
2007-10-05 22:31 ` Vlad Lungu
2007-10-06 0:20 ` Thomas Lange
2007-10-06 12:27 ` Vlad Lungu
2007-10-11 20:04 ` Shinya Kuribayashi
2007-10-11 22:06 ` Vlad Lungu
2007-10-12 10:20 ` Vlad Lungu
2007-10-14 15:57 ` Shinya Kuribayashi
2007-10-14 19:00 ` Vlad Lungu
2007-10-16 18:19 ` [U-Boot-Users] _gp in current u-boot.lds for MIPS ports Wolfgang Denk
2007-10-16 19:13 ` Vlad Lungu
2007-10-16 20:15 ` Andrew Dyer
2007-10-17 14:27 ` Shinya Kuribayashi
2007-10-17 14:23 ` Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470526A4.40903@comsys.ro \
--to=vlad@comsys.ro \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox