From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Lungu Date: Fri, 05 Oct 2007 13:39:36 +0300 Subject: [U-Boot-Users] [PATCH] Off-by-two bug when relocating GOT In-Reply-To: <4705B65A.5040206@necel.com> References: <470526A4.40903@comsys.ro> <4705B65A.5040206@necel.com> Message-ID: <47061468.5050709@comsys.ro> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Shinya Kuribayashi wrote: > Vlad Lungu wrote: > >> The first two entries are skipped but the number of relocated entries >> is not adjusted; as a result, the first __u_boot_cmd_* structure is >> smashed and no commands can be issued. >> > > This is a known, long stading, pretty critical, but not fixed problem. See below: > > http://search.gmane.org/search.php?group=gmane.comp.boot-loaders.u-boot&query=mips+got > > I'm going to look closely into this. > The thing I don't get is why skip the top two entries in the first place? Is it because _gp=ALIGN(16) ? Maybe Robert has a point: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/25533 Vlad