public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Lange <thomas@corelatus.se>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Off-by-two bug when relocating GOT
Date: Fri, 05 Oct 2007 22:18:11 +0200	[thread overview]
Message-ID: <47069C03.4070505@corelatus.se> (raw)
In-Reply-To: <47061468.5050709@comsys.ro>

Vlad Lungu wrote:
> Shinya Kuribayashi wrote:
>> Vlad Lungu wrote:
>>   
>>> The first two entries are skipped but the number of relocated entries
>>> is not adjusted; as a result, the first __u_boot_cmd_* structure is
>>> smashed and no commands can be issued.
>>>     
>> This is a known, long stading, pretty critical, but not fixed problem. See below:
>>
>> http://search.gmane.org/search.php?group=gmane.comp.boot-loaders.u-boot&query=mips+got
>>
>> I'm going to look closely into this.
>>   
> The thing I don't get is why skip the top two entries in the first place? Is it because 
> _gp=ALIGN(16) ? Maybe Robert has a point:
> 
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/25533

Yes, Roberts patch sent 12/15/06 09:53 worked for me when my command
table suddenly got corrupted.

It is still not applied to sources.

Is it rejected/pending/forgotten?

/Thomas

  reply	other threads:[~2007-10-05 20:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-04 17:45 [U-Boot-Users] [PATCH] Off-by-two bug when relocating GOT Vlad Lungu
2007-10-05  3:58 ` Shinya Kuribayashi
2007-10-05 10:39   ` Vlad Lungu
2007-10-05 20:18     ` Thomas Lange [this message]
2007-10-05 22:31       ` Vlad Lungu
2007-10-06  0:20         ` Thomas Lange
2007-10-06 12:27           ` Vlad Lungu
2007-10-11 20:04         ` Shinya Kuribayashi
2007-10-11 22:06           ` Vlad Lungu
2007-10-12 10:20             ` Vlad Lungu
2007-10-14 15:57             ` Shinya Kuribayashi
2007-10-14 19:00               ` Vlad Lungu
2007-10-16 18:19               ` [U-Boot-Users] _gp in current u-boot.lds for MIPS ports Wolfgang Denk
2007-10-16 19:13                 ` Vlad Lungu
2007-10-16 20:15                 ` Andrew Dyer
2007-10-17 14:27                   ` Shinya Kuribayashi
2007-10-17 14:23                 ` Shinya Kuribayashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47069C03.4070505@corelatus.se \
    --to=thomas@corelatus.se \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox