[U-Boot-Users] [PATCH] drivers: initial tree import for drivers reorganization

plagnioj at jcrosoft.com
2007-10-14T10:50:52Z

On 14:32 Thu 11 Oct , Grant Likely wrote:
> On 10/11/07, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>
> > LIBS += drivers/bios_emulator/libatibiosemu.a
> > +LIBS += drivers/block/libblock.a
> > +LIBS += drivers/char/libchar.a
>
> What is this? how is 'char' different from 'serial'? We don't have a
> char device API, so I don't understand how this fits in.
>
> You're moving keyboard drivers into here; so maybe merge with drivers/input.
>
For me char is a generic device driver.
> > +LIBS += drivers/hwmon/libhwmon.a
>
> We don't really have an hwmon api, and only one driver is being moved
> there which is an i2c device. Probably just merge with drivers/i2c.

During the next window I'd like to add a hwmon API that allow you to
check if the board could start, need to be stop, or need to start the
fan etc...
>
> merge with drivers/misc
>
> > +LIBS += drivers/misc/libmisc.a
> > +LIBS += drivers/mtd/libmtd.a
>
> eeprom and NAND might be better to go in here.
>
> > +LIBS += drivers/eeprom/libeeprom.a
>
> I'm not sure about this one; it feels kind of wrong (there can be i2c
> eeprom, SPI eeprom, etc). I need to think some more...
>
I agree about NAND, it will move to mtd
but not about eeprom could be use in other application to store
parameter like with USB switch, Net device, etc...

> > LIBS += drivers/net/libnet.a
> > +LIBS += drivers/pci/libpci.a
> > +LIBS += drivers/pcmcia/libpcmcia.a
>
> I'm tempted to just merge these under drivers/bus since it's not a lot
> of files... not sure though.
>
> > ifeq ($(CPU),mpc83xx)
> > LIBS += drivers/qe/qe.a
> > endif
> > ifeq ($(CPU),mpc85xx)
> > LIBS += drivers/qe/qe.a
> > endif
> > +LIBS += drivers/sata/libsata.a
>
> merge with drivers/block
I prefer to seperate each block type as scsi, sata and ide

Best Regards

Jean-Christophe PLAGNIOL-VILLARD