[U-Boot-Users] [PATCH] drivers/usb : move usb drivers to drivers/usb

Markus Klotzbücher
2007-10-15T10:31:25Z

Dear H?vard,

Haavard Skinnemoen <hskinnemoen@atmel.com> writes:

> On Sat, 13 Oct 2007 17:14:26 +0200
> plagnioj at jcrosoft.com wrote:
>
>> drivers/usb/serial/
>>
>> - e.g. serial support
>
> FWIW, Linux seems to be moving away from this structure. USB networking
> drivers are now under drivers/net, for example. Rationale (from the
> commit log):
>
> It is preferable to group drivers by usage (net, scsi, ATA, ...) than
> by bus. When reviewing drivers, the [PCI|USB|PCMCIA|...] maintainer
> is probably less qualified on networking issues than a networking
> maintainer. Also, from a practical standpoint, chips often
> appear on multiple buses, which is why we do not put drivers into
> drivers/pci/net.
>
> which doesn't necessarily mean that u-boot should do the same, but I
> think we should consider it. Besides, how many USB serial drivers apart
> from CDC are there, really?

I get your point, but I think U-Boot is somewhat different from linux
here. It might just as well be a architecture custodian or board
maintainer that that takes care of USB device XY. And as Wolfgang
pointed out custodians have to maintain code distributed across
different directories already (see POST layer).

But maybe it would make the upcoming kconfig system more intuitive if a
usb net driver was found under drivers-net instead of drivers-usb?!

Best regards

Markus Klotzb?cher

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de