From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Date: Fri, 12 Oct 2007 09:16:01 +0200 Subject: [U-Boot-Users] libfdt release? In-Reply-To: <20071012042811.GK21056@localhost.localdomain> References: <006E3CAD-11CB-4892-8BDB-9866677F371D@freescale.com> <20071010061458.GA6135@localhost.localdomain> <912BB32E-FD7D-4CBC-AE3D-3D358E97DECB@freescale.com> <20071011041239.GF14873@localhost.localdomain> <9917D225-2082-4900-BFD4-96490EA88C42@freescale.com> <470EB351.4070009@gmail.com> <20071012042811.GK21056@localhost.localdomain> Message-ID: <470F1F31.7060802@grandegger.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de David Gibson wrote: > On Thu, Oct 11, 2007 at 07:35:45PM -0400, Jerry Van Baren wrote: > [snip] >>>>> * Replace fdt_node_offset() with fdt_find_node_by_path(). >>>> There is no fdt_node_offset(), fdt_path_offset() they mean, maybe. >>>> And why a gratuitous name change...? >>> Jerry? >> We needed the function (Detlev, IIRC). The gratuitous name change was >> intended to be more descriptive. Perhaps if the correct original name >> were used, we wouldn't have needed a gratuitous name change. ;-) > > Heh. > > Do bear in mind in future that the naming conventions in libfdt aren't > arbitrary. I've tried to put "offset" in the name of everything that > returns a structure block offset as a hint to that return convention. > Additionally it's supposed to mitigate the big libfdt gotcha - that > offsets aren't handles, so the offset for a node can change if you > alter another node. I proposed the name change some time ago on this list: http://sourceforge.net/mailarchive/forum.php?thread_name=4639F61F.2050506%40grandegger.com&forum_name=u-boot-users And they have been accepted and nobody complained ;-). The main reason for the change was to make them (almost) compatible with the names used by Linux. I think that's useful when we start using FDT for configuring U-Boot. Wolfgang.