From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Lungu Date: Sun, 14 Oct 2007 22:00:51 +0300 Subject: [U-Boot-Users] [PATCH] Off-by-two bug when relocating GOT In-Reply-To: <47123C81.6050902@ruby.dti.ne.jp> References: <470526A4.40903@comsys.ro> <4705B65A.5040206@necel.com> <47061468.5050709@comsys.ro> <47069C03.4070505@corelatus.se> <4706BB27.5050108@comsys.ro> <470E81C4.8080908@ruby.dti.ne.jp> <470E9E70.7060508@comsys.ro> <47123C81.6050902@ruby.dti.ne.jp> Message-ID: <47126763.6060204@comsys.ro> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Shinya Kuribayashi wrote: > This is caused by lacking of -G0 in PLATFORM_LDFLAGS. I'm preparing a > patch as below, and will submit for review in the near future. > > There is nothing wrong with having sdata/scommon/sbbs. I was just pointing out that _gp and _G_O_T_ are not conceptually the same and if they are not equal, then the whole thing blows up with the current cpu/mips/start.S. See http://www.nabble.com/-PATCH--Fixed-the-_gp-_G_O_T_-confusion-for-good-tf4613248.html As long as there is nothing between the .got section and __got_end, it works, regardless of the alignment of _gp or __got_start(or even his presence) and num_got_entries is redundant at this point. Vlad