[U-Boot-Users] [patch] rtl8139.c: use PCI IO map

Shinya Kuribayashi
2007-10-13T15:46:26Z

Lucas Jin wrote:
> Wolfgang Denk Wrote:
>
>> In message <200710131722183904740@gmail.com> you wrote:
>>> Signed-off-by: Lucas Jin <lucasjin@gmail.com>
>>>
>>> --- ./drivers/rtl8139.c.orig 2007-10-12 22:17:52.000000000 +0800
>>> +++ ./drivers/rtl8139.c 2007-10-13 17:34:40.117515408 +0800
>> Could you please explain which problem this patch is supposed to fix?
>
> The rtl8139 specification says the configuration registers can be accessed through PCI memory mapping or PCI IO mapping.
>
> The u-boot driver uses PCI memory mapping, but it doesn't work, so I changed it to PCI IO mapping.

On my target RTL8139 or its variant works fine without such a change.
Why do you think doesn't work? Could you elaborate please?

> The driver of rtl8139 in Linux Kernel also uses PCI IO mapping to access the configuration registers.

Do you mean CONFIG_8139TOO_PIO?

thanks,

Shinya