From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shinya Kuribayashi Date: Sun, 21 Oct 2007 10:40:16 +0900 Subject: [U-Boot-Users] [PATCH] PHYSADDR is for physical address, KSEG1ADDR is for uncached In-Reply-To: <47123206.30403@ruby.dti.ne.jp> References: <470E6E62.3090105@comsys.ro> <47123206.30403@ruby.dti.ne.jp> Message-ID: <471AAE00.6060500@ruby.dti.ne.jp> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Shinya Kuribayashi wrote: > Hello, > > I'm going to pick up this patch into -mips repos, but several problems > are there. Please see below. Applied. I changed patch subject and TAB indent. thanks, Shinya > Vlad Lungu wrote: >> IMO, KSEG1 should work for AU1X00 too, but I can't test it > > Plase put an appropriate mail subject and patch description. > "PHYSADDR is for physical address, KSEG1ADDR is for uncached" > seems not be descriptive (at least for me). > > If not native english speaker (of course I'm not), it helps a lot to see > git log of others. > >> Signed-off-by: Vlad Lungu >> Signed-off-by: Shinya Kuribayashi >> >> --- >> include/asm-mips/addrspace.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/include/asm-mips/addrspace.h b/include/asm-mips/addrspace.h >> index b8214b1..0e6abd7 100644 >> --- a/include/asm-mips/addrspace.h >> +++ b/include/asm-mips/addrspace.h >> @@ -49,7 +49,7 @@ >> cannot access physical memory directly from core */ >> #define UNCACHED_SDRAM(a) (((unsigned long)(a)) | 0x20000000) >> #else /* !CONFIG_AU1X00 */ > > Indentation corrupted. Check your mailer settings. > >> -#define UNCACHED_SDRAM(a) PHYSADDR(a) >> +#define UNCACHED_SDRAM(a) KSEG1ADDR(a) >> #endif /* CONFIG_AU1X00 */ >> #endif /* __ASSEMBLY__ */ > > ditto. > >> /* > > As I'm excersizing repo management, please don't expect my quick > response ;-) > > thanks, > > Shinya