public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/1] Fix mips_io_port_base multiple	declaration
Date: Tue, 23 Oct 2007 00:26:28 +0900	[thread overview]
Message-ID: <471CC124.1010108@ruby.dti.ne.jp> (raw)
In-Reply-To: <1192954010-2408-1-git-send-email-plagnioj@jcrosoft.com>

Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> 
> diff --git a/board/dbau1x00/dbau1x00.c b/board/dbau1x00/dbau1x00.c
> index d29e8d5..687a69c 100644
> --- a/board/dbau1x00/dbau1x00.c
> +++ b/board/dbau1x00/dbau1x00.c
> @@ -26,6 +26,8 @@
>  #include <asm/au1x00.h>
>  #include <asm/mipsregs.h>
>  
> +unsigned long mips_io_port_base = 0;
> +
>  long int initdram(int board_type)
>  {
>  	/* Sdram is setup by assembler code */
> diff --git a/common/cmd_ide.c b/common/cmd_ide.c
> index bb064ea..feb89d6 100644
> --- a/common/cmd_ide.c
> +++ b/common/cmd_ide.c
> @@ -54,10 +54,6 @@
>  
>  #ifndef __PPC__
>  #include <asm/io.h>
> -#ifdef __MIPS__
> -/* Macros depend on this variable */
> -unsigned long mips_io_port_base = 0;
> -#endif
>  #endif
>  
>  #ifdef CONFIG_IDE_8xx_DIRECT

Thanks, but NACK. Please don't move it to dbau1x00 part.
See,

  http://article.gmane.org/gmane.comp.boot-loaders.u-boot/32132

Does this fix your problem? I'll pick this up after 1.3.0 is out.


  Shinya

      reply	other threads:[~2007-10-22 15:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-21  8:06 [U-Boot-Users] [PATCH 1/1] Fix mips_io_port_base multiple declaration Jean-Christophe PLAGNIOL-VILLARD
2007-10-22 15:26 ` Shinya Kuribayashi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471CC124.1010108@ruby.dti.ne.jp \
    --to=skuribay@ruby.dti.ne.jp \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox