* [U-Boot-Users] [PATCH 1/1] Fix mips_io_port_base multiple declaration
@ 2007-10-21 8:06 Jean-Christophe PLAGNIOL-VILLARD
2007-10-22 15:26 ` Shinya Kuribayashi
0 siblings, 1 reply; 2+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2007-10-21 8:06 UTC (permalink / raw)
To: u-boot
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
diff --git a/board/dbau1x00/dbau1x00.c b/board/dbau1x00/dbau1x00.c
index d29e8d5..687a69c 100644
--- a/board/dbau1x00/dbau1x00.c
+++ b/board/dbau1x00/dbau1x00.c
@@ -26,6 +26,8 @@
#include <asm/au1x00.h>
#include <asm/mipsregs.h>
+unsigned long mips_io_port_base = 0;
+
long int initdram(int board_type)
{
/* Sdram is setup by assembler code */
diff --git a/common/cmd_ide.c b/common/cmd_ide.c
index bb064ea..feb89d6 100644
--- a/common/cmd_ide.c
+++ b/common/cmd_ide.c
@@ -54,10 +54,6 @@
#ifndef __PPC__
#include <asm/io.h>
-#ifdef __MIPS__
-/* Macros depend on this variable */
-unsigned long mips_io_port_base = 0;
-#endif
#endif
#ifdef CONFIG_IDE_8xx_DIRECT
--
1.5.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot-Users] [PATCH 1/1] Fix mips_io_port_base multiple declaration
2007-10-21 8:06 [U-Boot-Users] [PATCH 1/1] Fix mips_io_port_base multiple declaration Jean-Christophe PLAGNIOL-VILLARD
@ 2007-10-22 15:26 ` Shinya Kuribayashi
0 siblings, 0 replies; 2+ messages in thread
From: Shinya Kuribayashi @ 2007-10-22 15:26 UTC (permalink / raw)
To: u-boot
Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>
> diff --git a/board/dbau1x00/dbau1x00.c b/board/dbau1x00/dbau1x00.c
> index d29e8d5..687a69c 100644
> --- a/board/dbau1x00/dbau1x00.c
> +++ b/board/dbau1x00/dbau1x00.c
> @@ -26,6 +26,8 @@
> #include <asm/au1x00.h>
> #include <asm/mipsregs.h>
>
> +unsigned long mips_io_port_base = 0;
> +
> long int initdram(int board_type)
> {
> /* Sdram is setup by assembler code */
> diff --git a/common/cmd_ide.c b/common/cmd_ide.c
> index bb064ea..feb89d6 100644
> --- a/common/cmd_ide.c
> +++ b/common/cmd_ide.c
> @@ -54,10 +54,6 @@
>
> #ifndef __PPC__
> #include <asm/io.h>
> -#ifdef __MIPS__
> -/* Macros depend on this variable */
> -unsigned long mips_io_port_base = 0;
> -#endif
> #endif
>
> #ifdef CONFIG_IDE_8xx_DIRECT
Thanks, but NACK. Please don't move it to dbau1x00 part.
See,
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/32132
Does this fix your problem? I'll pick this up after 1.3.0 is out.
Shinya
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-22 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-21 8:06 [U-Boot-Users] [PATCH 1/1] Fix mips_io_port_base multiple declaration Jean-Christophe PLAGNIOL-VILLARD
2007-10-22 15:26 ` Shinya Kuribayashi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox