From: Ben Warren <bwarren@qstreams.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] DHCP Client Fix
Date: Sun, 28 Oct 2007 22:00:03 -0400 [thread overview]
Message-ID: <47253EA3.7010500@qstreams.com> (raw)
In-Reply-To: <20071028220117.E732F24756@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Justin,
>
> in message <4155D0DA4B6B044891B3F19311C7E7B89C45E4@EXCHANGE1.886llc.local> you wrote:
>
>> I recently upgraded the firmware on some of my old Linksys WRT54G
>> routers (version 5) from firmware version 1.0.6 to firmware version
>> 1.02.2, both of which are released by Linksys and U-Boot was no longer
>> able to get an IP address using DHCP. However, with the older firmware
>> (version 1.0.6), U-Boot was still able to get an IP through DHCP.
>>
>> Using a hub and a packet sniffer, I was able to locate the problem. The
>> U-Boot code will bind to an IP address offered by the DHCP server
>> prematurely and the DHCP server will not respond with an ACK, rendering
>>
>
> I have to admit that I'm not sure if this is a bug in U-Boot or in
> the Linksys router (which I have under special observation as they
> explicitely and intentionally violate the U-Boot GPL).
>
>
>> the system without an IP address. This is no longer valid when using a
>> Linksys router as DHCP server. I modified the code to operate the way
>> the Linux DHCP client does by not binding to the offered IP until the
>> DHCP client receives the ACK sent by the server, ending the
>> conversation. After making the appropriate changes, DCHP service was
>> restored for all flavors of the Linksys firmware that I have available
>> (v 1.02.2 and v1.0.6 for the version 5 router, v8.00.2 for the version 8
>> router). It has also been tested on an AirPort Extreme router running
>> DHCP.
>>
>> Attached is the patch with the code changes that were made. Any feed
>> back would be appreciated.
>>
>
> I'm waiting for feedback (or a pull request?) from the network
> custodian.
>
> Ben???
>
>
This looks promising. I'll provide feedback after doing some testing
tomorrow.
regards,
Ben
next prev parent reply other threads:[~2007-10-29 2:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 14:15 [U-Boot-Users] [PATCH] DHCP Client Fix Justin Flammia
2007-10-28 22:01 ` Wolfgang Denk
2007-10-29 2:00 ` Ben Warren [this message]
2007-10-29 6:00 ` [U-Boot-Users] Return values from u-boot to standalone application Leonid
2007-10-29 13:34 ` Leonid
2007-10-29 13:46 ` Laurent Pinchart
2007-10-29 14:45 ` Leonid
2007-10-29 19:46 ` [U-Boot-Users] Return values from u-boot to standaloneapplication Leonid
-- strict thread matches above, loose matches on Subject: below --
2007-10-29 14:00 [U-Boot-Users] [PATCH] DHCP Client Fix Justin Flammia
2007-10-29 21:40 Justin Flammia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47253EA3.7010500@qstreams.com \
--to=bwarren@qstreams.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox