From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Mon, 29 Oct 2007 13:33:43 -0400 Subject: [U-Boot-Users] [PATCH] PPC4xx: Add Ethernet 1000BASE-X support for PPC4xx In-Reply-To: <472611C8.4050107@arlinx.com> References: <472611C8.4050107@arlinx.com> Message-ID: <47261977.4020009@qstreams.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Larry Johnson wrote: > This patch adds a new switch: "CONFIG_PHY_DYNAMIC_ANEG". When this symbol > is defined, the PHY will advertise it's capabilities for autonegotiation > based on the capabilities shown in the PHY's status registers, including > 1000BASE-X. When "CONFIG_PHY_DYNAMIC_ANEG" is not defined, the PHY will > advertise hard-coded capabilities, as before. > I won't address the content yet, just the cosmetic changes that make up the bulk of this patch. I think you've done a good thing by running Lindent (or whatever) on all the files you've touched, but it has the effect of obscuring the meat of your work. No need to re-do it this time, but IMHO, purely cosmetic changes should be separate patches and labeled as such. Of course, that's just MHO, and others may feel differently. Thoughts? regards, Ben