public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Aggelos Manousarides <amanous@inaccessnetworks.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Spartan FPGA patch
Date: Tue, 30 Oct 2007 17:51:21 +0200	[thread overview]
Message-ID: <472752F9.9000307@inaccessnetworks.com> (raw)

The following patch fixes a bug in the slave serial programming mode for 
the xilinx spartan2 FPGA. A "char val" is declared, but it is used as a 
signed char. The check for negative value (<0) is always true on arm, or 
any other platform in which the char is not signed by default. As a 
result the FPGA cannot be programmed.

By the way, I have tested this code and it works fine, apart from this 
error. I am using it in ARM platforms in both slave parallel and slave 
serial modes. I am this because I don't see any other platforms using it.

This is a patch against 1.2.0, but I saw that the same code exists in 
1.3.0-rc3 as well.

--
Angelos Manousarides

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fpga.patch
Type: text/x-patch
Size: 420 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20071030/55725c8e/attachment.bin 

             reply	other threads:[~2007-10-30 15:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30 15:51 Aggelos Manousarides [this message]
2007-11-03 21:46 ` [U-Boot-Users] Spartan FPGA patch Wolfgang Denk
2007-11-05 12:58   ` Aggelos Manousarides
2007-11-05 19:21     ` Wolfgang Denk
2007-11-07 11:43       ` Aggelos Manousarides
2007-11-07 13:33         ` Wolfgang Denk
2007-11-07 16:49           ` Andreas Schweigstill
2007-11-07 19:51             ` Wolfgang Denk
2007-11-14 12:05               ` Aggelos Manousarides
2007-11-14 19:46                 ` Wolfgang Denk
2007-11-07 14:29       ` Matthias Fuchs
2007-11-07 19:48         ` Wolfgang Denk
2007-11-07 21:07           ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472752F9.9000307@inaccessnetworks.com \
    --to=amanous@inaccessnetworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox